1417387 - TypeError: 'unicode' does not have the buffer interface

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Florian Quèze [:florian]]

$ ./mach build
Error running mach:

    ['build']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

TypeError: 'unicode' does not have the buffer interface

  File "/Users/florian/buildhg/mozilla/python/mozbuild/mozbuild/mach_commands.py", line 170, in build
    mach_context=self._mach_context)
  File "/Users/florian/buildhg/mozilla/python/mozbuild/mozbuild/controller/building.py", line 1128, in build
    keep_going=keep_going)
  File "/Users/florian/buildhg/mozilla/python/mozbuild/mozbuild/controller/building.py", line 1337, in _run_client_mk
    if self._check_clobber(mozconfig, os.environ):
  File "/Users/florian/buildhg/mozilla/python/mozbuild/mozbuild/controller/building.py", line 1381, in _check_clobber
    clobber_output)
  File "/Users/florian/buildhg/mozilla/python/mozbuild/mozbuild/controller/clobber.py", line 192, in maybe_do_clobber
    print('Automatically clobbering %s' % self.topobjdir, file=fh)


$ python --version
Python 2.7.13
$ python3 --version
Python 3.6.3
$ cat mozconfig
mk_add_options AUTOCLOBBER=1
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-browser


Moving away the obj directory by hand worked.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Bug 1417387 - Don't mix unicode and bytes in clobber code;

b6adf66f34c6 (bug 1416052) changed the value for "fh" when this code
is called. It can now be an io.BytesIO. This type enforces that
arguments are bytes and doesn't perform automatic type coercion like
most other parts of Python 2.

self.topobjdir is a unicode. And unicode_literals isn't in effect
in this file. So convert self.topobjdir to bytes to make BytesIO
happy.

Review commit: https://reviewboard.mozilla.org/r/199868/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199868/

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8928634 [details]
Bug 1417387 - Don't mix unicode and bytes in clobber code;

https://reviewboard.mozilla.org/r/199868/#review204982

Gah, so hard to deal with these issues in Python 2.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62b191e02145
Don't mix unicode and bytes in clobber code; r=nalexander

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/62b191e02145