1417409 - Statistics panel doesn't produce any data

Status: RESOLVED WORKSFORME

(DevTools :: Netmonitor, defect, P1)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

STR:
1) load any page
2) Open the Toolbox, select the Net panel and click on the 'Analyze' button
3) The statistics panel doesn't show any results.

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@Alex: could this regression be caused by the recent lazy loading
of the response body? (bug 1404917)

Honza

Comment 2

[Alexandre Poirot [:ochameau]]

This is because contentSize here is undefined for some requests:
https://searchfox.org/mozilla-central/rev/a662f122c37704456457a526af90db4e3c0fd10e/devtools/client/netmonitor/src/components/StatisticsPanel.js#77
      req.contentSize !== undefined && req.mimeType && req.responseHeaders &&

And so the request isn't considered as ready and we wait before updating the stats.

contentSize is undefined because for some request we never get `responseContent` event and never trigger this code, which sets it:
https://searchfox.org/mozilla-central/rev/a662f122c37704456457a526af90db4e3c0fd10e/devtools/client/netmonitor/src/connector/firefox-data-provider.js#413

It looks unrelated to bug 1404917 as it should change much contentSize behavior.
I tried reverting it locally and Stats panel still fails.

It looks more related to bug 1372115, which clearly breaks responseContent events.
And if I apply bug 1372115 comment 8 patch, Stats panel works again.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks Alex for the analysis!
Honza

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Bug 1372115 has been fixed and the Stats view works as expected, closing.
Honza