Closed Bug 1417436 Opened 2 years ago Closed 2 years ago

Add Windows code coverage build definition

Categories

(Testing :: Code Coverage, enhancement)

enhancement
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: marco, Assigned: marco)

References

Details

Attachments

(1 file)

It's not completely green yet (https://treeherder.mozilla.org/#/jobs?repo=try&revision=c580333a3b7cb8e7f0200d49e62a6f2856651524), but I think we can start landing the build and test definitions.
Attached patch PatchSplinter Review
There are still a few todos, but I think we can start landing this and take care of the todos in follow-ups.
Attachment #8928507 - Flags: review?(jmaher)
Comment on attachment 8928507 [details] [diff] [review]
Patch

Review of attachment 8928507 [details] [diff] [review]:
-----------------------------------------------------------------

overall this is good, I have some nits and questions.

::: browser/config/mozconfigs/win64/code-coverage
@@ +5,5 @@
> +ac_add_options --target=x86_64-pc-mingw32
> +ac_add_options --host=x86_64-pc-mingw32
> +
> +ac_add_options --enable-optimize
> +ac_add_options --enable-debug

why do we have both optimize and debug?

::: taskcluster/ci/test/test-platforms.yml
@@ +216,5 @@
> +        - awsy
> +        - desktop-screenshot-capture
> +        - windows-reftest-gpu
> +        - windows-talos
> +        - windows-talos-stylo-disabled

we don't need stylo-disabled; these are going away soon.

::: taskcluster/ci/test/xpcshell.yml
@@ +20,5 @@
>                      - unittests/win_taskcluster_unittest.py
>          requires-signed-builds:
>              by-test-platform:
>                  windows10-64-asan/opt: false    # No XPCShell on ASAN yet
> +                windows10-64-ccov/debug: false  # TODO: Sign build.

can we sign coverage builds?  if not, we can disable moz_updater in the build config.

::: testing/mozharness/configs/builds/taskcluster_firefox_win64_ccov_debug.py
@@ +30,5 @@
> +        ],
> +    },
> +    'app_ini_path': '%(obj_dir)s/dist/bin/application.ini',
> +    # decides whether we want to use moz_sign_cmd in env
> +    'enable_signing': True,

I thought for xpcshell we were not signing things
Attachment #8928507 - Flags: review?(jmaher) → review+
(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #2)
> Comment on attachment 8928507 [details] [diff] [review]
> Patch
> 
> Review of attachment 8928507 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> overall this is good, I have some nits and questions.
> 
> ::: browser/config/mozconfigs/win64/code-coverage
> @@ +5,5 @@
> > +ac_add_options --target=x86_64-pc-mingw32
> > +ac_add_options --host=x86_64-pc-mingw32
> > +
> > +ac_add_options --enable-optimize
> > +ac_add_options --enable-debug
> 
> why do we have both optimize and debug?

We need to enable optimizations, as otherwise the build would be extremely slow.


> ::: taskcluster/ci/test/test-platforms.yml
> @@ +216,5 @@
> > +        - awsy
> > +        - desktop-screenshot-capture
> > +        - windows-reftest-gpu
> > +        - windows-talos
> > +        - windows-talos-stylo-disabled
> 
> we don't need stylo-disabled; these are going away soon.

I'll remove it


> ::: taskcluster/ci/test/xpcshell.yml
> @@ +20,5 @@
> >                      - unittests/win_taskcluster_unittest.py
> >          requires-signed-builds:
> >              by-test-platform:
> >                  windows10-64-asan/opt: false    # No XPCShell on ASAN yet
> > +                windows10-64-ccov/debug: false  # TODO: Sign build.
> 
> can we sign coverage builds?  if not, we can disable moz_updater in the
> build config.

I'd like to keep them as similar as possible to the normal Windows debug builds, so I'd like to sign them. I don't know how to do that though.


> ::: testing/mozharness/configs/builds/taskcluster_firefox_win64_ccov_debug.py
> @@ +30,5 @@
> > +        ],
> > +    },
> > +    'app_ini_path': '%(obj_dir)s/dist/bin/application.ini',
> > +    # decides whether we want to use moz_sign_cmd in env
> > +    'enable_signing': True,
> 
> I thought for xpcshell we were not signing things

I'm hoping we will be able to sign the builds, but I haven't figured out how to do it yet.
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6053c68a9bc6
Add Windows code coverage build and test definitions. r=jmaher
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0685df5dc52a
Add Windows code coverage build and test definitions: Add linebreak in long comment to fix flake8 error. r=linting-fix
https://hg.mozilla.org/mozilla-central/rev/6053c68a9bc6
https://hg.mozilla.org/mozilla-central/rev/0685df5dc52a
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
The amount of test failures for this platform is not sustainable. Can you move it to Tier 3 so it gets hidden on Treeherder by default until there no perma failures and less failures on average, please?
Flags: needinfo?(mcastelluccio)
Depends on: 1418479
(In reply to Sebastian Hengst [:aryx][:archaeopteryx] (needinfo on intermittent or backout) from comment #7)
> The amount of test failures for this platform is not sustainable. Can you
> move it to Tier 3 so it gets hidden on Treeherder by default until there no
> perma failures and less failures on average, please?

Will do. I've opened bug 1418479 for this.
Flags: needinfo?(mcastelluccio)
Depends on: 1115253
No longer depends on: 1115253
You need to log in before you can comment on or make changes to this bug.