Update about:debugging to use prop-types and react-dom-factories

RESOLVED FIXED in Firefox 59

Status

()

Firefox
Developer Tools: about:debugging
P2
normal
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: miker, Assigned: miker)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

There are a number of reasons for this:

1. We need to have the modules available for code from devtools-core, which uses them.
2. It begins the process of getting rid of React deprecation warnings.
3. It prepares us to upgrade to React 16.

Versioning info from devtools-core github repo:

"prop-types": "^15.6.0"
"react-dom-factories": "^1.0.2"
Comment hidden (mozreview-request)

Comment 2

2 months ago
mozreview-review
Comment on attachment 8928522 [details]
Bug 1417444 - about:debugging to use prop-types and react-dom-factories

https://reviewboard.mozilla.org/r/199778/#review205904

Looks good to me. r+ with a green try
Attachment #8928522 - Flags: review?(jdescottes) → review+

Comment 3

2 months ago
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/58593f36fc8f
about:debugging to use prop-types and react-dom-factories r=jdescottes

Comment 4

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/58593f36fc8f
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.