Closed Bug 1417472 Opened 2 years ago Closed 2 years ago

[Fennec Relpro] publish_fennec action graph doesn't take artifacts from parent graph

Categories

(Release Engineering :: Release Automation: Other, defect, P1, blocker)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jlorenzo, Assigned: aki)

Details

(Whiteboard: [releaseduty])

Attachments

(1 file)

Steps to reproduce
1. Follow steps described at [1], but assign ACTION_TASK_ID to UruW-tHOTzCcKzuLxAfVIA. This task represent the relpro graph of Fenec 58.0b3 build 4.

Results
This graph is created[3]. As you can see in there, the build tasks are created (and run) again. I cancelled the graph, after confirming with Rail that this graph does too much.

After some investigation, Rail thinks there's something wrong at the optimization step of the action task. What do you think, Aki? 

[1] https://github.com/mozilla/releasewarrior/blob/28b8ec0ff49c291f4e5aabb30fa0817347e8c51d/how-tos/fennec-temp-relpro.md#kick-off-publish-action-task
[2] https://tools.taskcluster.net/groups/UruW-tHOTzCcKzuLxAfVIA
[3] https://tools.taskcluster.net/groups/QlmjXkx_S2G_rOjkqKeejw
Flags: needinfo?(aki)
Sounds like https://hg.mozilla.org/mozilla-central/rev/9fc12ae8a2e7#l6.36 is setting do_not_optimize to

set(['android-push-apk-breakpoint/opt',
     u'beetmover-android-aarch64-nightly/opt',
     u'beetmover-android-api-16-nightly/opt',
     u'beetmover-android-x86-nightly/opt',
     u'beetmover-checksums-android-aarch64-nightly/opt',
     u'beetmover-checksums-android-api-16-nightly/opt',
     u'beetmover-checksums-android-x86-nightly/opt',
     u'build-android-aarch64-nightly/opt',
     u'build-android-aarch64-nightly/opt-upload-symbols',
     u'build-android-api-16-nightly/opt',
     u'build-android-api-16-nightly/opt-upload-symbols',
     u'build-android-api-16-old-id-nightly/opt-upload-symbols',
     u'build-android-x86-nightly/opt',
     u'build-android-x86-nightly/opt-upload-symbols',
     u'build-android-x86-old-id-nightly/opt-upload-symbols',
     u'build-signing-android-aarch64-nightly/opt',
     u'build-signing-android-api-16-nightly/opt',
     u'build-signing-android-x86-nightly/opt',
     u'checksums-signing-android-aarch64-nightly/opt',
     u'checksums-signing-android-api-16-nightly/opt',
     u'checksums-signing-android-x86-nightly/opt',
     'push-apk/opt',
     u'release-bouncer-aliases-fennec',
     u'release-bouncer-sub-fennec',
     u'release-mark-as-shipped-fennec',
     u'release-notify-promote-fennec',
     u'release-notify-publish-fennec',
     u'release-uptake-monitoring-fennec',
     u'release-version-bump-fennec',
     u'upload-generated-sources-android-aarch64-nightly/opt',
     u'upload-generated-sources-android-api-16-nightly/opt',
     u'upload-generated-sources-android-api-16-old-id-nightly/opt',
     u'upload-generated-sources-android-x86-nightly/opt',
     u'upload-generated-sources-android-x86-old-id-nightly/opt'])

This way they are not filtered out by the optimizer.
This is probably the fix. Running taskgraph-gen.py and taskgraph-diff.py to make sure this doesn't do anything unexpected.
Assignee: nobody → aki
Flags: needinfo?(aki)
Attachment #8928598 - Flags: review?(rail)
Comment on attachment 8928598 [details] [diff] [review]
fix-publish-fennec

IRC r+ 09:28 <rail> ship it!
Attachment #8928598 - Flags: review?(rail) → review+
Pushed by asasaki@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/80cb926578e4
start optimizing beta and release tasks. r=rail DONTBUILD
No builds!

action task: https://tools.taskcluster.net/groups/Kxj_5MnZSsOBgOSmgJPqug/tasks/WJHti58xSs60QiaR0FTcnw/runs/0
publish graph: https://tools.taskcluster.net/groups/WJHti58xSs60QiaR0FTcnw
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.