1417501 - Console tests are failing when run in isolation

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

In Bug 1404917, we introduced loading the /devtools/client/netmonitor/test/shared-head.js file in devtools/client/webconsole/new-console-output/test/mochitest/head.js [1].
But, the shared file is not declared in browser.ini, which ends up making variable from head.js inaccessible, and some tests that relies on them to fail.

i.e. running

> /mach test  devtools/client/webconsole/new-console-output/test/mochitest/


makes the following tests fail :
> - browser_netmonitor_shows_reqs_in_webconsole.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/webconsole/new-console-output/test/mochitest/browser_netmonitor_shows_reqs_in_webconsole.js:68 - ReferenceError: waitForExistingRequests is not defined
> - browser_netmonitor_shows_reqs_in_webconsole.js | A promise chain failed to handle a rejection: 'getEventTimings' pending request packet to 'server1.conn28.child1/netEvent27' can't be sent as the connection just closed. - stack: null
> - browser_netmonitor_shows_reqs_in_webconsole.js | A promise chain failed to handle a rejection: 'getSecurityInfo' active request packet to 'server1.conn28.child1/netEvent27' can't be sent as the connection just closed. - stack: null
> - browser_webconsole_allow_mixedcontent_securityerrors.js | Exception thrown - at chrome://mochitests/content/browser/devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_allow_mixedcontent_securityerrors.js:19 - ReferenceError: can't access lexical declaration `DOCS_GA_PARAMS' before initialization
> - browser_webconsole_block_mixedcontent_securityerrors.js | Exception thrown - at chrome://mochitests/content/browser/devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_block_mixedcontent_securityerrors.js:22 - ReferenceError: can't access lexical declaration `DOCS_GA_PARAMS' before initialization
> - browser_webconsole_keyboard_accessibility.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_keyboard_accessibility.js:51 - TypeError: WCUL10n is undefined
> - browser_webconsole_network_attach.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_network_attach.js:53 - ReferenceError: waitForExistingRequests is not defined
> - browser_webconsole_network_messages_openinnet.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_network_messages_openinnet.js:80 - ReferenceError: waitForExistingRequests is not defined
> - browser_webconsole_network_messages_openinnet.js | A promise chain failed to handle a rejection: 'getSecurityInfo' pending request packet to 'server1.conn54.child1/netEvent27' can't be sent as the connection just closed. - stack: null
> - browser_webconsole_network_messages_openinnet.js | A promise chain failed to handle a rejection: 'getEventTimings' active request packet to 'server1.conn54.child1/netEvent27' can't be sent as the connection just closed. - stack: null
> - browser_webconsole_observer_notifications.js | Uncaught exception - waitFor - timed out after 500 tries.

This was not picked up by TRY because the netmonitor tests are ran before the console's one, which loads /devtools/client/netmonitor/test/shared-head.js .


[1] https://hg.mozilla.org/mozilla-central/diff/291c051b7861/devtools/client/webconsole/new-console-output/test/mochitest/head.js#l1.21

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1417501 - Add devtools/client/netmonitor/test/shared-head.js in console browser.ini; .

In Bug 1404917, we introduced loading the
/devtools/client/netmonitor/test/shared-head.js
file in devtools/client/webconsole/new-console-output/test/mochitest/head.js.
But, the shared file is not declared in browser.ini,
which ends up making variabled from head.js inaccessible,
and some tests that relies on them to fail.

This was not picked up by TRY because the netmonitor tests
are ran before the console's one, which loads
devtools/client/netmonitor/test/shared-head.js .

Review commit: https://reviewboard.mozilla.org/r/199814/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199814/

Comment 2

[Alexandre Poirot [:ochameau]]

Comment on attachment 8928579 [details]
Bug 1417501 - Add devtools/client/netmonitor/test/shared-head.js in console browser.ini; .

https://reviewboard.mozilla.org/r/199814/#review204912

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0b8c266d7bf
Add devtools/client/netmonitor/test/shared-head.js in console browser.ini; r=ochameau.

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/f0b8c266d7bf