1417554 - Convert moznetwork test to pytest format

Status: RESOLVED FIXED

(Testing :: Mozbase, enhancement)

Description

[Andrew Halberstadt [:ahal]]

See bug 1397417 for the tracking bug with motivations for this change.

Here is the pytest documentation:
https://docs.pytest.org/en/latest/contents.html

That is a lot of information, but this bug is basically about modifying 'testing/mozbase/moznetwork/tests/test.py' to make better use of pytest (it is already running under pytest, but is structured as a unittest test).

This means:

1. Use 'assert foo == bar' instead of self.assertEquals(foo, bar)
2. Use module level test functions instead of unittest.TestCase based classes
3. Convert the 'verify_ip_in_list' function to a fixture which returns a function. More information on how fixtures work can be found here:
https://docs.pytest.org/en/latest/fixture.html

Changes can be tested with:
./mach python-test testing/mozbase/moznetwork

Or on try with:
./mach try fuzzy -q "'mozbase"

(or leave off the -q to choose it in the selection interface)

Comment 1

[Andrew Halberstadt [:ahal]]

And of course, you'll need to test the lints as well:
./mach lint testing/mozbase/moznetwork

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Bug 1417554 - Use plain assert statements.

Review commit: https://reviewboard.mozilla.org/r/200292/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200292/

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Bug 1417554 - Use module level test functions instead of unittest.TestCase classes.

Review commit: https://reviewboard.mozilla.org/r/200294/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200294/

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Bug 1417554 - Use a session scoped fixture for obtaining the host IP addresses.

Review commit: https://reviewboard.mozilla.org/r/200296/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200296/

Comment 5

[Andrew Halberstadt [:ahal]]

Comment on attachment 8928952 [details]
Bug 1417554 - Use plain assert statements.

https://reviewboard.mozilla.org/r/200292/#review206436

Comment 6

[Andrew Halberstadt [:ahal]]

Comment on attachment 8928953 [details]
Bug 1417554 - Use module level test functions instead of unittest.TestCase classes.

https://reviewboard.mozilla.org/r/200294/#review206438

Comment 7

[Andrew Halberstadt [:ahal]]

Comment on attachment 8928954 [details]
Bug 1417554 - Use a session scoped fixture for obtaining the host IP addresses.

https://reviewboard.mozilla.org/r/200296/#review206440

Thanks Dave!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/327cf77dc7b4
Use plain assert statements. r=ahal
https://hg.mozilla.org/integration/autoland/rev/3b9b4134fbe8
Use module level test functions instead of unittest.TestCase classes. r=ahal
https://hg.mozilla.org/integration/autoland/rev/017c3d88e600
Use a session scoped fixture for obtaining the host IP addresses. r=ahal

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/327cf77dc7b4
https://hg.mozilla.org/mozilla-central/rev/3b9b4134fbe8
https://hg.mozilla.org/mozilla-central/rev/017c3d88e600