Closed
Bug 1417558
Opened 8 years ago
Closed 8 years ago
MOZ_MUST_USE for structured clone readBytes()
Categories
(Core :: JavaScript Engine, enhancement, P2)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: sfink, Assigned: sfink)
Details
Attachments
(1 file)
|
8.80 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
readBytes() should really be MOZ_MUST USE, and do reportTruncated() or MOZ_CRASH.
|
||
Updated•8 years ago
|
status-firefox59:
--- → affected
Priority: -- → P2
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → sphink
Flags: needinfo?(sphink)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Sorry Jon, not sure who else to send this review to. The one surprising one is the MOZ_ALWAYS_TRUE, which is guaranteed by the previous check that we have at least sizeof(uint64_t) bytes available.
Attachment #8930270 -
Flags: review?(jcoppeard)
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8930270 [details] [diff] [review]
MOZ_MUST_USE read*() return values in structured clone
Review of attachment 8930270 [details] [diff] [review]:
-----------------------------------------------------------------
No problem. Looks good.
Attachment #8930270 -
Flags: review?(jcoppeard) → review+
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ccc752e4699f
MOZ_MUST_USE read*() return values in structured clone, r=jonco
|
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•