Closed Bug 1417558 Opened 3 years ago Closed 3 years ago

MOZ_MUST_USE for structured clone readBytes()

Categories

(Core :: JavaScript Engine, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: sfink, Assigned: sfink)

Details

Attachments

(1 file)

readBytes() should really be MOZ_MUST USE, and do reportTruncated() or MOZ_CRASH.
Priority: -- → P2
Steve, can you take?
Flags: needinfo?(sphink)
Assignee: nobody → sphink
Flags: needinfo?(sphink)
Sorry Jon, not sure who else to send this review to. The one surprising one is the MOZ_ALWAYS_TRUE, which is guaranteed by the previous check that we have at least sizeof(uint64_t) bytes available.
Attachment #8930270 - Flags: review?(jcoppeard)
Comment on attachment 8930270 [details] [diff] [review]
MOZ_MUST_USE read*() return values in structured clone

Review of attachment 8930270 [details] [diff] [review]:
-----------------------------------------------------------------

No problem.  Looks good.
Attachment #8930270 - Flags: review?(jcoppeard) → review+
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ccc752e4699f
MOZ_MUST_USE read*() return values in structured clone, r=jonco
https://hg.mozilla.org/mozilla-central/rev/ccc752e4699f
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.