1417595 - [MIPS] Implement missing parts of Bug 1417398

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P5)

Description

[Dragan Mladjenovic]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.106 Safari/537.36

Comment 1

[Dragan Mladjenovic]

Attachment: bug1417595.diff

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8928650 [details] [diff] [review]
bug1417595.diff

Review of attachment 8928650 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks. Note that there will be more changes to this code in bug 1417398.

Comment 3

[Jan de Mooij [:jandem]]

(In reply to Jan de Mooij [:jandem] from comment #2)
> Thanks. Note that there will be more changes to this code in bug 1417398.

I just landed bug 1417398; this will need to be rebased. Sorry for the churn!

Comment 4

[Dragan Mladjenovic]

Attachment: bug1417595_2.patch

Hi,
Sorry for the late response. I've updated the bug to refer to Bug 1417398. I've also included a small change to JitRuntime::startTrampolineCode to reset masm's framePushed to zero at every new start of trampoline code. This is done in order to satisfy debug asserts in mips's trampolines from before when each trampoline code gen renewed its own instance of MacroAssembler.

Comment 5

[Jan de Mooij [:jandem]]

Comment on attachment 8930066 [details] [diff] [review]
bug1417595_2.patch

Review of attachment 8930066 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f2c44121da3
Implement missing parts of Bug 1417398. r=jandem

Comment 7

[Natalia Csoregi [:nataliaCs]]

Backed out for Spidermonkey build bustage on Linux x64 Debug src/js/src/jit/MacroAssembler.h:419

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/7c9f541b4722f4622401178127e865970ab45175

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=2b6b5af4a1f22a7862facee78d7b982ed2726b0f

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=146465434&repo=mozilla-inbound&lineNumber=1994

Comment 8

[Dragan Mladjenovic]

(In reply to Natalia Csoregi [:nataliaCs] from comment #7)
> Backed out for Spidermonkey build bustage on Linux x64 Debug
> src/js/src/jit/MacroAssembler.h:419
> 
> Backout:
> https://hg.mozilla.org/integration/mozilla-inbound/rev/
> 7c9f541b4722f4622401178127e865970ab45175
> 
> Push with failures:
> https://treeherder.mozilla.org/#/jobs?repo=mozilla-
> inbound&revision=2b6b5af4a1f22a7862facee78d7b982ed2726b0f
> 
> Failure log:
> https://treeherder.mozilla.org/logviewer.html#?job_id=146465434&repo=mozilla-
> inbound&lineNumber=1994

I haven't been able to reproduce this failure on my local setup (clang-4.0 / gcc 4.9.4). Is the gcc used by this build publicly available for download ?

Comment 9

[Jan de Mooij [:jandem]]

You probably need to include MacroAssembler-inl.h in Ion.cpp.

This is the non-unified build, an easy way to build like this locally is to s/UNIFIED_SOURCES/SOURCES/ in js/src/moz.build

Comment 10

[Dragan Mladjenovic]

(In reply to Jan de Mooij [:jandem] from comment #9)
> You probably need to include MacroAssembler-inl.h in Ion.cpp.
> 
> This is the non-unified build, an easy way to build like this locally is to
> s/UNIFIED_SOURCES/SOURCES/ in js/src/moz.build

Thanks. It was it. I should now provide an updated version of this patch and again mark this bug report with checkin-needed ? Or there is a different procedure to follow in this case. Also Bug1418990 patch was backed out along with this patch.

Comment 11

[Jan de Mooij [:jandem]]

(In reply to Dragan Mladjenovic from comment #10)
> Thanks. It was it. I should now provide an updated version of this patch and
> again mark this bug report with checkin-needed ? Or there is a different
> procedure to follow in this case. Also Bug1418990 patch was backed out along
> with this patch.

Yeah that's fine. Mark bug 1418990 as checkin-needed and post an updated patch for this bug and mark it checkin-needed too.

When you add the missing #include, just make sure the ordering is correct.

Comment 12

[Dragan Mladjenovic]

Attachment: bug1417595_3.patch

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d1cdd68d47b
[MIPS] Implement missing parts of Bug 1417398. r=jandem

Comment 14

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/3d1cdd68d47b