1417597 - Page actions Send Tabs should show a different feedback message when offline

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P1)

Description

[Ryan Feeley [:rfeeley]]

Attachment: no-internet-connection.png

STEPS TO REPRODUCE
1. Take your device offline (two cases: disable network in OS or "Work Offline" in Firefox)
2. Go to a web page
3. Go to the Page Action Menu
4. Select Send Tab to Device

EXPECTED RESULTS
- The user is informed that they are offline

ACTUAL RESULTS
- A list of devices appear
- The user can select a device or all devices
- ✅ Sent! appears
- The tab is never sent

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Note that the feature should still work - the tab will be sent when the device comes back online. So do you really want to block that entirely, or instead should we warn but allow them to proceed?

Comment 2

[Edouard Oger [:eoger]]

Attachment: Bug 1417597 - Show a different feedback message in send tab when we're offline.

Review commit: https://reviewboard.mozilla.org/r/200458/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200458/

Comment 3

[Ryan Feeley [:rfeeley]]

I spoke with Bryan Bell, and we should go with: Queued! (offline)

Comment 4

[Edouard Oger [:eoger]]

Comment on attachment 8929166 [details]
Bug 1417597 - Show a different feedback message in send tab when we're offline.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/200458/diff/1-2/

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8929166 [details]
Bug 1417597 - Show a different feedback message in send tab when we're offline.

https://reviewboard.mozilla.org/r/200458/#review205590

::: browser/locales/en-US/chrome/browser/browser.dtd:54
(Diff revision 1)
>  <!ENTITY  sendPageToDevice.label             "Send Page to Device">
>  <!ENTITY  sendPageToDevice.accesskey         "n">
>  <!ENTITY  sendLinkToDevice.label             "Send Link to Device">
>  <!ENTITY  sendLinkToDevice.accesskey         "n">
>  <!ENTITY  sendToDeviceFeedback.label         "Sent!">
> +<!ENTITY  sendToDeviceOfflineFeedback.label  "Queued!">

"Queued!" might be a bit too technical and doesn't describe why it's not sent. The user may have a spotty internet connection and not even know that they are currently offline.

(I also am not fond of the exclamation point in a non-success situation like this.)

We should get some feedback from Michelle Heubusch about what to say here. I think "Will send when back online" fits better to me.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8929166 [details]
Bug 1417597 - Show a different feedback message in send tab when we're offline.

Michelle, what text should we show when the user is offline and tries to send a page to another device? The page will be sent once the user reconnects to the internet.

Currently we just say "Sent!" in all cases
The patch here proposes "Queued!" in the offline case
I think we should use something like "Will send when back online" (no exclamation point)

Comment 7

[Ryan Feeley [:rfeeley]]

Michelle: Bryan and Eric both prefer: Queued! (offline)

Comment 8

[mheubusch]

please use Queued (offline)  for now (no exclamation point) - I will work with UR to test other messages for comprehension (like Pending or On hold

Comment 9

[Edouard Oger [:eoger]]

Comment on attachment 8929166 [details]
Bug 1417597 - Show a different feedback message in send tab when we're offline.

Thanks Michelle, clearing the f? flag.

Comment 10

[Edouard Oger [:eoger]]

Comment on attachment 8929166 [details]
Bug 1417597 - Show a different feedback message in send tab when we're offline.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/200458/diff/2-3/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c849056fcf2
Show a different feedback message in send tab when we're offline. r=jaws

Comment 12

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/5c849056fcf2