1417666 - Improve field filter clearing workflows

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, enhancement, P3)

Description

[Jonathan French (:jfrench)]

I noticed a couple of possible minor improvements for the field filter bar.

1) we have an unused function removeAllFieldFilters() and a viable place to use it in the field filter bar by replacing the inert 'i' Active Filters icon with a clickable equivalent. This will allow users to clear lots of field filters with a single-click if they wish. Currently the have to close them individually.

2) if we re-ordered the small 'x' closure buttons from the end of each filter to the front of each filter, the user will be able remove multiple filters sequentially without having to move their mouse to arbitrary points on screen (similar to removing jobs from the pinboard). An added benefit it associates the close icon with the corresponding field (and tooltip), rather than the field's value.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] tojon:clear-filterbar > mozilla:master

Comment 2

[Jonathan French (:jfrench)]

Comment on attachment 8928703 [details] [review]
[treeherder] tojon:clear-filterbar > mozilla:master

It seems there's a generalized problem w/Travis right now, but I'm comfortable putting this up for review anyway.

Comment 3

[Ed Morley [:emorley]]

> It seems there's a generalized problem w/Travis right now 

This is now fixed on master, if it helps :-)

Comment 4

[Jonathan French (:jfrench)]

Cool, ty! :) I'll push a new SHA shortly to trigger another Travis run.

Comment 5

[Jonathan French (:jfrench)]

Ok, we have a passing Travis now for this PR. This is ready for review at your leisure.

Comment 6

[Jonathan French (:jfrench)]

Comment on attachment 8928703 [details] [review]
[treeherder] tojon:clear-filterbar > mozilla:master

Still some things we might want to add, so r- the PR for now for camd.

Comment 7

[Cameron Dawson [:camd]]

Heh, I was just about to do that.  Thanks bud.  :)

Comment 8

[Jonathan French (:jfrench)]

Comment on attachment 8928703 [details] [review]
[treeherder] tojon:clear-filterbar > mozilla:master

Ok I've tested everything except `nojobs`, and the Non-field filters in isolation or in combinations with all Field filters all appear to be cleared correctly with the new Clear all icon. I'll put this back up for review.

Comment 9

[Cameron Dawson [:camd]]

Comment on attachment 8928703 [details] [review]
[treeherder] tojon:clear-filterbar > mozilla:master

This is awesome, man.  Thanks for doing this!  :)

Comment 10

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/029c035c4790898cc3bc5ea7f5b60192ccfd50aa
Bug 1417666 - Improve field filter clearing workflows