1417689 - Move elfhack related things to python configure

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1417689 - Remove explicit --enable-elf-hack in mozconfigs.

--enable-elf-hack is the default on all platforms where it's supported,
and is completely ignored on platforms where it's not supported.
While moving the flag to moz.configure, we're going to make it only
work on platforms where elfhack is supported, so we at least need to
remove it from mozconfigs for those platforms where it's not supported.
But generally speaking, we want less things in mozconfigs, so just
remove it from there, since it's the default anyways.

Review commit: https://reviewboard.mozilla.org/r/200038/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200038/

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1417689 - Move elfhack related things to python configure.

Review commit: https://reviewboard.mozilla.org/r/200040/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200040/

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8928760 [details]
Bug 1417689 - Remove explicit --enable-elf-hack in mozconfigs.

https://reviewboard.mozilla.org/r/200038/#review205150

Comment 4

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8928761 [details]
Bug 1417689 - Move elfhack related things to python configure.

https://reviewboard.mozilla.org/r/200040/#review205152

lgtm.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa0234108fd0
Remove explicit --enable-elf-hack in mozconfigs. r=nalexander
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b1914b0d83e
Move elfhack related things to python configure. r=nalexander

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/fa0234108fd0
https://hg.mozilla.org/mozilla-central/rev/5b1914b0d83e

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c7449572b78c
Keep build files in sync (Port Bug 1417689: Remove explicit --enable-elf-hack in mozconfigs). rs=bustage-fix