Closed Bug 1417698 Opened 5 years ago Closed 4 years ago

Use mozilla recommended eslint rules and remove rules duplicating those recommendations

Categories

(Firefox :: WebPayments UI, enhancement, P1)

Product:
Firefox
Component:
WebPayments UI
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 60
Tracking Flags:
Tracking Status
firefox59 --- wontfix
firefox60 --- fixed

People

(Reporter: MattN, Assigned: 2042, Mentored)

References

(
URL
)

Details

(Keywords: good-first-bug, Whiteboard: [webpayments])

Attachments

(1 file)

patch for activity code cadets
837 bytes, patch
MattN
: review+
Details | Diff | Splinter Review 
https://dxr.mozilla.org/mozilla-central/source/toolkit/components/payments/.eslintrc.js should use the recommended rules while keeping some stricter ones that aren't yet part of the recommended ones.
Priority: -- → P3
Hi MattN, can you please explain in detail the changes this bug requires.
Thanks.
We have two files:
https://searchfox.org/mozilla-central/source/toolkit/components/payments/.eslintrc.js
and
https://searchfox.org/mozilla-central/source/tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js

The .eslintrc.js file extends what is already defined by the recommended.js file. Anything that is duplicated between the two should be removed. I looked at the two files and found the only rule that was duplicated with the same values was the `semi` rule which is at https://searchfox.org/mozilla-central/rev/33c90c196bc405e628bc868a4f4ba29b992478c0/toolkit/components/payments/.eslintrc.js#51

Line 51 should be removed to fix this bug.
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #2)
> We have two files:
> https://searchfox.org/mozilla-central/source/toolkit/components/payments/.
> eslintrc.js
> and
> https://searchfox.org/mozilla-central/source/tools/lint/eslint/eslint-plugin-
> mozilla/lib/configs/recommended.js
> 
> The .eslintrc.js file extends what is already defined by the recommended.js
> file. Anything that is duplicated between the two should be removed. I
> looked at the two files and found the only rule that was duplicated with the
> same values was the `semi` rule which is at
> https://searchfox.org/mozilla-central/rev/
> 33c90c196bc405e628bc868a4f4ba29b992478c0/toolkit/components/payments/.
> eslintrc.js#51
> 
> Line 51 should be removed to fix this bug.

 Can i fix this bug?
Yes, please go ahead and fix this bug. I will mark it as assigned to you when you have a patch uploaded.
Flags: needinfo?(akriti.v10)
Attachment #8944580 - Flags: review?(MattN+bmo)
Assignee: nobody → 2042
Status: NEW → ASSIGNED
Flags: needinfo?(akriti.v10)
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/mozilla-inbound/rev/810037ffe4a8
Remove redundant `semi` eslint rule from toolkit/components/payments/. r=MattN
Attachment #8944580 - Flags: review?(MattN+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/810037ffe4a8
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Priority: P3 → P1
Whiteboard: [webpayments]
Product: Toolkit → Firefox
Target Milestone: mozilla60 → Firefox 60
You need to log in before you can comment on or make changes to this bug.