Use mozilla recommended eslint rules and remove rules duplicating those recommendations
RESOLVED
FIXED
in Firefox 60
Status
()
People
(Reporter: MattN, Assigned: 2042, Mentored)
Tracking
({good-first-bug})
Firefox Tracking Flags
(firefox59 wontfix, firefox60 fixed)
Details
(Whiteboard: [webpayments], URL)
Attachments
(1 attachment)
|
837 bytes,
patch
|
MattN
:
review+
|
Details | Diff | Splinter Review |
https://dxr.mozilla.org/mozilla-central/source/toolkit/components/payments/.eslintrc.js should use the recommended rules while keeping some stricter ones that aren't yet part of the recommended ones.
Mentor: jaws
Keywords: good-first-bug
|
(Reporter) | |
Updated•a year ago
|
Priority: -- → P3
|
||
Comment 1•a year ago
|
||
Hi MattN, can you please explain in detail the changes this bug requires. Thanks.
|
||
Comment 2•a year ago
|
||
We have two files: https://searchfox.org/mozilla-central/source/toolkit/components/payments/.eslintrc.js and https://searchfox.org/mozilla-central/source/tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js The .eslintrc.js file extends what is already defined by the recommended.js file. Anything that is duplicated between the two should be removed. I looked at the two files and found the only rule that was duplicated with the same values was the `semi` rule which is at https://searchfox.org/mozilla-central/rev/33c90c196bc405e628bc868a4f4ba29b992478c0/toolkit/components/payments/.eslintrc.js#51 Line 51 should be removed to fix this bug.
|
|
||
Comment 3•a year ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #2) > We have two files: > https://searchfox.org/mozilla-central/source/toolkit/components/payments/. > eslintrc.js > and > https://searchfox.org/mozilla-central/source/tools/lint/eslint/eslint-plugin- > mozilla/lib/configs/recommended.js > > The .eslintrc.js file extends what is already defined by the recommended.js > file. Anything that is duplicated between the two should be removed. I > looked at the two files and found the only rule that was duplicated with the > same values was the `semi` rule which is at > https://searchfox.org/mozilla-central/rev/ > 33c90c196bc405e628bc868a4f4ba29b992478c0/toolkit/components/payments/. > eslintrc.js#51 > > Line 51 should be removed to fix this bug. Can i fix this bug?
|
|
||
Comment 4•a year ago
|
||
Yes, please go ahead and fix this bug. I will mark it as assigned to you when you have a patch uploaded.
Flags: needinfo?(akriti.v10)
|
|
(Reporter) | |
Updated•a year ago
|
Attachment #8944580 -
Flags: review?(MattN+bmo)
|
|
(Reporter) | |
Updated•a year ago
|
Assignee: nobody → 2042
Status: NEW → ASSIGNED
Flags: needinfo?(akriti.v10)
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/mozilla-inbound/rev/810037ffe4a8 Remove redundant `semi` eslint rule from toolkit/components/payments/. r=MattN
|
|
(Reporter) | |
Updated•a year ago
|
Attachment #8944580 -
Flags: review?(MattN+bmo) → review+
|
||
Comment 7•a year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/810037ffe4a8
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
|
||
Updated•a year ago
|
status-firefox59: affected → wontfix
|
||
Updated•a year ago
|
Priority: P3 → P1
Whiteboard: [webpayments]
Component: WebPayments UI → WebPayments UI
Product: Toolkit → Firefox
Target Milestone: mozilla60 → Firefox 60
You need to log in
before you can comment on or make changes to this bug.
Description
•