Closed
Bug 1417709
Opened 7 years ago
Closed 6 years ago
Invisible -moz-mac-window-titlebar creates an unnecessary webrender image item
Categories
(Core :: Graphics: WebRender, enhancement, P1)
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: mstange, Assigned: mstange)
References
Details
(Whiteboard: [wr-reserve])
Attachments
(5 files)
59 bytes,
text/x-review-board-request
|
jrmuizel
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
emilio
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
jrmuizel
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
emilio
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
johannh
:
review+
|
Details |
In the Mac window we have an element with -moz-appearance: -moz-window-titlebar underneath the tab bar. The tab bar has -moz-appearance: -moz-mac-vibrancy-dark and blocks out the "titlebar" completely. With WebRender we don't do any client-side occlusion culling, so we create unnecessary images for covered nsDisplayThemedBackground items. This creates some overhead which we'd like to avoid. The reason that -moz-appearance: -moz-window-titlebar is set on something invisible is to make double-clicking in the right areas of the window minimize or zoom the window. That's because there's special handling for this -moz-appearance value in nsChildView.mm. I'm going to create new -moz-appearance values called -moz-mac-vibrant-titlebar-dark and -moz-mac-vibrant-titlebar-light which can be set on the tab bar while also achieving the correct double click behavior.
Updated•7 years ago
|
Priority: -- → P1
Whiteboard: [wr-reserve]
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•6 years ago
|
||
The servo changes are in https://github.com/servo/servo/pull/19255 .
Comment 7•6 years ago
|
||
mozreview-review |
Comment on attachment 8929108 [details] Bug 1417709 - Change GatherThemeGeometryRegion to GatherVibrantRegion. https://reviewboard.mozilla.org/r/200400/#review205614 ::: commit-message-af42b:2 (Diff revision 1) > +Bug 1417709 - Change GatherThemeGeometryRegion to GatherVibrantRegion. r?jrmuizel > + Why?
Attachment #8929108 -
Flags: review?(jmuizelaar) → review+
Comment 8•6 years ago
|
||
mozreview-review |
Comment on attachment 8929110 [details] Bug 1417709 - Implement -moz-appearance: -moz-mac-vibrant-titlebar-light/dark on macOS. https://reviewboard.mozilla.org/r/200404/#review205616
Attachment #8929110 -
Flags: review?(jmuizelaar) → review+
Comment 9•6 years ago
|
||
mozreview-review |
Comment on attachment 8929109 [details] Bug 1417709 - Add -moz-appearance: -moz-mac-vibrant-titlebar-light/dark. https://reviewboard.mozilla.org/r/200402/#review205636
Attachment #8929109 -
Flags: review?(emilio) → review+
Comment 10•6 years ago
|
||
mozreview-review |
Comment on attachment 8929111 [details] Bug 1417709 - Add system colors called "-moz-mac-vibrant-titlebar-light/dark" for use with -moz-font-smoothing-background-color. https://reviewboard.mozilla.org/r/200406/#review205640
Attachment #8929111 -
Flags: review?(emilio) → review+
Comment 11•6 years ago
|
||
mozreview-review |
Comment on attachment 8929112 [details] Bug 1417709 - Use -moz-appearance: -moz-mac-vibrant-titlebar-dark/light in the Firefox UI. https://reviewboard.mozilla.org/r/200408/#review205924 Looks good and works for me, thank you!
Attachment #8929112 -
Flags: review?(jhofmann) → review+
Updated•6 years ago
|
Blocks: stage-wr-trains
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 17•6 years ago
|
||
Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/a0fe569c86c0 Change GatherThemeGeometryRegion to GatherVibrantRegion. r=jrmuizel https://hg.mozilla.org/integration/autoland/rev/e3a6c5b74595 Add -moz-appearance: -moz-mac-vibrant-titlebar-light/dark. r=emilio https://hg.mozilla.org/integration/autoland/rev/29e6c0d82193 Implement -moz-appearance: -moz-mac-vibrant-titlebar-light/dark on macOS. r=jrmuizel https://hg.mozilla.org/integration/autoland/rev/50f0febe43a0 Add system colors called "-moz-mac-vibrant-titlebar-light/dark" for use with -moz-font-smoothing-background-color. r=emilio https://hg.mozilla.org/integration/autoland/rev/5670c9582add Use -moz-appearance: -moz-mac-vibrant-titlebar-dark/light in the Firefox UI. r=johannh
Comment 18•6 years ago
|
||
Backed out changeset 2e20100d8f59 (bug 1417709) for error in toolkit/library/rust/target r=backout on a CLOSED TREE https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=5670c9582add98a9fd29a42249a326949028ad85&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&selectedJob=146918215 https://hg.mozilla.org/integration/autoland/rev/2e112c82206c8debbaa915aec25f086ef38902ee
Flags: needinfo?(mstange)
Comment 19•6 years ago
|
||
Backed out 5 changesets (bug 1417709) for failing X in devtools/shared/tests/unit/test_css-properties-db.js r=backout on a CLOSED TREE https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2e20100d8f59223fdbade863fd4245894a232b46&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&selectedJob=146903287 https://hg.mozilla.org/integration/autoland/rev/cb9898849653827705e19a56afc59e1146fb48a4
Assignee | ||
Comment 20•6 years ago
|
||
Oh no :( I forgot to regenerate the devtools property database... This backout is probably also going to trip up the servo sync bot.
Comment 21•6 years ago
|
||
(In reply to Markus Stange [:mstange] from comment #20) > Oh no :( > > I forgot to regenerate the devtools property database... > > This backout is probably also going to trip up the servo sync bot. Yeah... It would've been nice to not back it out directly, but asking on IRC. Too late now I guess, oh well :(
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 27•6 years ago
|
||
Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/86505eb29b2c Change GatherThemeGeometryRegion to GatherVibrantRegion. r=jrmuizel https://hg.mozilla.org/integration/autoland/rev/2957fe3b0d53 Add -moz-appearance: -moz-mac-vibrant-titlebar-light/dark. r=emilio https://hg.mozilla.org/integration/autoland/rev/77ef4df9b8df Implement -moz-appearance: -moz-mac-vibrant-titlebar-light/dark on macOS. r=jrmuizel https://hg.mozilla.org/integration/autoland/rev/000e6eab5b25 Add system colors called "-moz-mac-vibrant-titlebar-light/dark" for use with -moz-font-smoothing-background-color. r=emilio https://hg.mozilla.org/integration/autoland/rev/42ca009ff87f Use -moz-appearance: -moz-mac-vibrant-titlebar-dark/light in the Firefox UI. r=johannh
Comment 28•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/86505eb29b2c https://hg.mozilla.org/mozilla-central/rev/2957fe3b0d53 https://hg.mozilla.org/mozilla-central/rev/77ef4df9b8df https://hg.mozilla.org/mozilla-central/rev/000e6eab5b25 https://hg.mozilla.org/mozilla-central/rev/42ca009ff87f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(mstange)
You need to log in
before you can comment on or make changes to this bug.
Description
•