Closed Bug 1417761 Opened 3 years ago Closed 3 years ago

Remove pref "layout.css.text-combine-upright.enabled"

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox59 --- wontfix
firefox60 --- wontfix
firefox61 --- fixed

People

(Reporter: xidorn, Assigned: gerald)

References

Details

Attachments

(1 file)

It has been shipped since Firefox 48, and other browsers have similar impls, and the related spec has been in CR since a while ago. The syntax of this property we implemented should be considered to be pretty stable, so I think we can remove this pref.
Priority: -- → P3
Having a go at it.
Assignee: nobody → gsquelart
Comment on attachment 8971464 [details]
Bug 1417761 - Remove "layout.css.text-combine-upright.enabled" pref -

https://reviewboard.mozilla.org/r/240212/#review246022

::: modules/libpref/init/all.js:2902
(Diff revision 1)
>  // Is support for CSS text-combine-upright: digits 2-4 enabled?
>  pref("layout.css.text-combine-upright-digits.enabled", false);

This pref is no longer effective because stylo doesn't include this. Could you add a followup patch to remove this pref and any related code as well?
Attachment #8971464 - Flags: review?(xidorn+moz) → review+
Thank you for the lightning-quick review Xidorn.


(In reply to Xidorn Quan [:xidorn] UTC+10 from comment #3)
> >  // Is support for CSS text-combine-upright: digits 2-4 enabled?
> >  pref("layout.css.text-combine-upright-digits.enabled", false);
> This pref is no longer effective because stylo doesn't include this. Could
> you add a followup patch to remove this pref and any related code as well?

No chance this may instead be re-implemented in Stylo one day?
(In reply to Gerald Squelart [:gerald] from comment #4)
> (In reply to Xidorn Quan [:xidorn] UTC+10 from comment #3)
> > >  // Is support for CSS text-combine-upright: digits 2-4 enabled?
> > >  pref("layout.css.text-combine-upright-digits.enabled", false);
> > This pref is no longer effective because stylo doesn't include this. Could
> > you add a followup patch to remove this pref and any related code as well?
> 
> No chance this may instead be re-implemented in Stylo one day?

Implementing the style part is easy, but the layout part is hard, so we are not going to revive its style part until we decide to work on the layout part.

Actually the usefulness of "digits" value as it's currently defined is unclear either, given it's easy to cause undesired result if not used carefully. Currently only Edge implemented that, and I don't think Chrome has plan for this at the moment either.
Blocks: 1457373
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e502da324b70
Remove "layout.css.text-combine-upright.enabled" pref - r=xidorn
https://hg.mozilla.org/mozilla-central/rev/e502da324b70
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.