1417775 - Always use shorter version preference string in dropdown footer

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, enhancement, P3)

Description

[Ray Lin[:ralin]]

In order to minimize the chance that footer string breaking into two lines, let's use short version string all the times.

Comment 1

[Ray Lin[:ralin]]

Attachment: Bug 1417775 - Always use short version preferences string on form autofill dropdown footer.

Review commit: https://reviewboard.mozilla.org/r/201528/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/201528/

Comment 2

[Ray Lin[:ralin]]

This should be something irrelevant to translation, so I just removed the long version string from locales, though the "Short" suffix seems pointless now.

Comment 3

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8930384 [details]
Bug 1417775 - Always use short version preferences string on form autofill dropdown footer.

https://reviewboard.mozilla.org/r/201528/#review207276

::: browser/extensions/formautofill/locales/en-US/formautofill.properties:54
(Diff revision 1)
>  updateCreditCardLabel = Update Credit Card
>  updateCreditCardAccessKey = U
>  # LOCALIZATION NOTE (openAutofillMessagePanel): Tooltip label for Form Autofill doorhanger icon on address bar.
>  openAutofillMessagePanel = Open Form Autofill message panel
>  
> -# LOCALIZATION NOTE (autocompleteFooterOption, autocompleteFooterOptionOSX): Used as a label for the button,
> +# LOCALIZATION NOTE ( (autocompleteFooterOptionShort, autocompleteFooterOptionOSXSho): Used as a label for the button,

missing "rt" in `autocompleteFooterOptionOSXShort`

::: browser/extensions/formautofill/locales/en-US/formautofill.properties:55
(Diff revision 1)
>  updateCreditCardAccessKey = U
>  # LOCALIZATION NOTE (openAutofillMessagePanel): Tooltip label for Form Autofill doorhanger icon on address bar.
>  openAutofillMessagePanel = Open Form Autofill message panel
>  
> -# LOCALIZATION NOTE (autocompleteFooterOption, autocompleteFooterOptionOSX): Used as a label for the button,
> -# displayed at the bottom of the drop down suggestion, to open Form Autofill browser preferences.
> +# LOCALIZATION NOTE ( (autocompleteFooterOptionShort, autocompleteFooterOptionOSXSho): Used as a label for the button,
> +# displayed at the bottom of the dropdown suggestion, to open Form Autofill browser preferences.

Maybe we can comment here to remind us that "Short" suffix should be removed upon strings change next time. (so that we won't get "autocompleteFooterOptionShort2"...)

Comment 4

[Ray Lin[:ralin]]

Comment on attachment 8930384 [details]
Bug 1417775 - Always use short version preferences string on form autofill dropdown footer.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/201528/diff/1-2/

Comment 5

[Ray Lin[:ralin]]

Comment on attachment 8930384 [details]
Bug 1417775 - Always use short version preferences string on form autofill dropdown footer.

https://reviewboard.mozilla.org/r/201528/#review207276

> Maybe we can comment here to remind us that "Short" suffix should be removed upon strings change next time. (so that we won't get "autocompleteFooterOptionShort2"...)

Good point! Thanks! instead, I leave the comment inside the binding as we discussed, so won't mess up the translation.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/499c048e1ed0
Always use short version preferences string on form autofill dropdown footer. r=lchang

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/499c048e1ed0