1417813 - Nightly starts without an icon; browser/icons is missing

Status: RESOLVED WORKSFORME

(Toolkit :: Themes, defect, P1)

Description

[Lars T Hansen [:lth]]

Ubuntu 16.

After updating Nightly this morning the icon in the dock is a big question mark, not the charming Nightly logo.  Digging around, it appears the subdirectory browser/icons is missing.  Creating that, and creating a link mozicon128.png in that directory into the browser/chrome/icons/default directory restores the missing icon on startup.

Comment 1

[Jonathan Kingston [:jkt] he/him]

Not sure where these icons have gone, however it's a regression from this week.

Comment 2

[Dão Gottwald [:dao]]

m_kato, could you please look into this?

Comment 3

[Makoto Kato [:m_kato]]

(In reply to Lars T Hansen [:lth] from comment #0)
> Ubuntu 16.
> 
> After updating Nightly this morning the icon in the dock is a big question
> mark, not the charming Nightly logo.  Digging around, it appears the
> subdirectory browser/icons is missing.  Creating that, and creating a link
> mozicon128.png in that directory into the browser/chrome/icons/default
> directory restores the missing icon on startup.

Firefox doesn't distribute *.desktop file.  So we or your package from a distribution should update icon entry to current path.

Comment 4

[Makoto Kato [:m_kato]]

s/So we or your package/you or your package/

Comment 5

[Lars T Hansen [:lth]]

Not sure what that's supposed to mean.  This is Nightly downloaded from firefox.com and run out of a user directory.  That's where I installed it initially and it's been there for many months, auto-updating happily, until the other day when the icon suddenly disappeared.  The icon was pinned to the ubuntu task bar but that doesn't seem to have anything to do with anything, since unpinning it and then just running firefox out of the directory also brings up the big question mark icon, not the appropriate nightly icon.

Comment 6

[Makoto Kato [:m_kato]]

It means that you have *.desktop file in .local/share/application (I don't have Ubuntu installation now, it is general GNOME case).  So you have to edit icon entry in this file.

It might be better we keep file (mozicon128.png)... for old compatibility like Lars's case... (But file name is mozicon128.png, but it can change to 256x256 for more hidpi).

Comment 7

[Lars T Hansen [:lth]]

I see.  Yes, I do have such a file, and if I fix the Icon entry to point into browser/chrome/icons/default and remove my workaround directory things still work OK.  Thanks.

(If I don't have the file in .local/share/applications then Ubuntu presents me with the normal Firefox icon when I launch Nightly, and if that Icon is pinned to the taskbar it will later open the release version of Firefox.  That is weird, though I'm sure there's a good explanation for it.  I expect it's not our (Mozilla's) fault but if it is it might be nice to fix it.)

Feel free to close this bug if you don't think there's anything more actionable here; I'm satisfied.  Thanks once more.