1417819 - Browsing files to insert image will not insert file path to "Image Location" line

Status: RESOLVED FIXED

(SeaMonkey :: Composer, defect)

Description

[kimdillman59]

User Agent: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36

Steps to reproduce:

start a new html page in SM Composer, saved and closed the file.

reopen the file to edit, insert image. 



Actual results:

browse button worked, but image was not inserted.  check box "URL is relative to page location" was inactive.


Expected results:

image file name should have appeared in the window and checkbox should have been active.

Comment 1

[Rainer Bielefeld]

REPRODUCIBLE with unzipped installer of  official en-US SeaMonkey 2.53a1 (NT 6.1; WOW64; rv:56.0) Gecko/20100101 Firefox/56.0 Build 20170706013410  (Default Classic Theme) on German WIN7 64bit

Steps:
1. In HTML Web Page COMPOSER
2. Menu ˋInsert → Image → Chosse file ... → Browse for file  →  [Open]ˊ
   » Path is in "Image Location" line
3. [Ok]
   » Image appears
4. Save File 
5. Redo from Step 2
   Bug: after [Open] image path does NOT appear in "Image Location" line

Comment 2

[Rainer Bielefeld]

a) Regression
a1) Already reproducible with  Installation of official DE SeaMonkey 2.49.1  
   (NT 6.1; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0 Build 20171016030418 
   (Default Classic Theme) on German WIN7 64bit
a2) Was still ok with 2.49a1  20161107002359 
a3) I did not check whether the problem is caused by a difference between unzipped and
    installed SM - but I doubt that that can be a reason.

b) Not only Images affected, same problem with ˋInsert → Linkˊ

c) another appearance of 
   "Bug 796994 - Use filepicker's open() instead of the obsolete show() in /suite/*"?
   I don't understand details of bug 1322172
   I will test with 2.55

Comment 3

[Rainer Bielefeld]

a4) Still REPRODUCIBLE with unzipped installer of  official en-US SeaMonkey 2.55a1 
   (NT 6.1; WOW64; rv:58.0) Gecko/20100101 Firefox/58.0 Build 20171110010345  
   (Default Classic Theme) on German WIN7 64bit
d) (a4) seems to show that this one is not a DUP of bug 1322172 ?

Currently I don't have time to search for DUPs

Comment 4

[Frank-Rainer Grahl (:frg)]

> I don't understand details of bug 1322172

SeaMonkey now saves images as data urls in the mail and news composer. File references relative or not are ignored and/or need to be unblocked. This has likely spilled over to composer but does not make sense here and if this is the cause needs to be fixed for composer only. Try to copy and image from the clipboard and see if this still works.

Bug 796994 has nothing to do with it.

Comment 5

[Frank-Rainer Grahl (:frg)]

Composer is partially broken in 2.55 because of nsIDOM removals. Not all are fixed yet. The problem was reported against 2.49.1 so I would test with this and prior versions only. As far as I know works all fine in 2.48.

Comment 6

[Rainer Bielefeld]

(In reply to Frank-Rainer Grahl (:frg) from comment #5)
(a2) Was still ok with 2.49a1  20161107002359
     indeed it seems that the problem came up with 2.49.1

Comment 7

[Frank-Rainer Grahl (:frg)]

I overlooked one GetOS() usage when doing bug 1364772. This causes the image properties dialog to fail partially.

Comment 8

[Frank-Rainer Grahl (:frg)]

Attachment: 1417819-imagecomposer.patch

[Approval Request Comment]
Regression caused by (bug #): bug 1364772
User impact if declined: image composition broken.
Testing completed (on m-c, etc.): c-r with 2.53.
Risk to taking this patch (and alternatives if risky): non already broken.
String changes made by this patch: none

Comment 9

[Frank-Rainer Grahl (:frg)]

Attachment: 1417819-imagecomposer-253.patch

Patch for 2.53 (just in case we do a 56 branch).

Comment 10

[Frank-Rainer Grahl (:frg)]

Attachment: 1417819-imagecomposer-esr52.patch

Patch for comm-esr52

Comment 11

[Frank-Rainer Grahl (:frg)]

Attachment: 1417819-imagecomposer-esr52.patch

esr52 patch was bad. Didn't remove a line during rebase.

Comment 12

[Ian Neal]

Comment on attachment 8930631 [details] [diff] [review]
1417819-imagecomposer.patch

LGTM r/a=me

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4424cbfd2136
Replace undefined GetOS() with Appconstants.platform. r=IanN

Comment 14

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-beta/rev/1def2ae81de0bdb24715d5508d1f944fec64aab7
https://hg.mozilla.org/releases/comm-esr52/rev/a666671966e41903407f27dc7d3c17895278057c

Comment 16

[LD Nova]

Where do I get the fixed version.  Im sorry, I'm new here and Im not understanding exactly how this works.  Will the new version be put on the top page when it's ready??. I had to uninstall, as my Seamonkey really wasn't functioning. This image problem had no go around that I could find. If you drag and drop, the source code is not right. You get a huge long code with no image name. It works on your desktop but no doubt won't work online.  Same problem with the background image. It will work once or twice but as soon as you start working, it will stop working and then you can't change the bg.

Comment 18

[Frank-Rainer Grahl (:frg)]

The new version will be announced on https://www.seamonkey-project.org/

There is no ETA yet. We hope this year but need to fix some other bugs for it first too. If you urgently need a prerelease version send me an email.

Comment 21

[hjim2416]

Sea Monkey opened up with an updated version of 2.49.1 to download. After doing so, nothing changed. Composer still does not work.

Comment 22

[Frank-Rainer Grahl (:frg)]

The fix will be in 2.49.2. There is only one 2.49.1. Not sure why you were updated.

Comment 26

[Frank-Rainer Grahl (:frg)]

Target 2.53.1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/fde16c76bb92d890e87f0e2e7894561b975b8a2e