Browsing files to insert image will not insert file path to "Image Location" line

RESOLVED FIXED in seamonkey2.56

Status

defect
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: kimdillman59, Assigned: frg)

Tracking

({regression, reproducible})

SeaMonkey 2.49 Branch
seamonkey2.56
Unspecified
All
Dependency tree / graph

SeaMonkey Tracking Flags

(seamonkey2.49esr fixed, seamonkey2.50 unaffected, seamonkey2.51 unaffected, seamonkey2.52 wontfix, seamonkey2.53 affected, seamonkey2.54 wontfix, seamonkey2.55 fixed, seamonkey2.56 fixed)

Details

Attachments

(3 attachments, 1 obsolete attachment)

Reporter

Description

2 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36

Steps to reproduce:

start a new html page in SM Composer, saved and closed the file.

reopen the file to edit, insert image. 



Actual results:

browse button worked, but image was not inserted.  check box "URL is relative to page location" was inactive.


Expected results:

image file name should have appeared in the window and checkbox should have been active.
Assignee

Updated

2 years ago
Flags: needinfo?(frgrahl)
Assignee

Updated

2 years ago
Flags: needinfo?(frgrahl)
See Also: → 1322172
Assignee

Updated

2 years ago
Flags: needinfo?(frgrahl)

Comment 1

2 years ago
REPRODUCIBLE with unzipped installer of  official en-US SeaMonkey 2.53a1 (NT 6.1; WOW64; rv:56.0) Gecko/20100101 Firefox/56.0 Build 20170706013410  (Default Classic Theme) on German WIN7 64bit

Steps:
1. In HTML Web Page COMPOSER
2. Menu ˋInsert → Image → Chosse file ... → Browse for file  →  [Open]ˊ
   » Path is in "Image Location" line
3. [Ok]
   » Image appears
4. Save File 
5. Redo from Step 2
   Bug: after [Open] image path does NOT appear in "Image Location" line
Summary: insert image not working in edit page - except in new, unsaved page → Browsing files to insert image will not insert file path to "Image Location" line

Comment 2

2 years ago
a) Regression
a1) Already reproducible with  Installation of official DE SeaMonkey 2.49.1  
   (NT 6.1; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0 Build 20171016030418 
   (Default Classic Theme) on German WIN7 64bit
a2) Was still ok with 2.49a1  20161107002359 
a3) I did not check whether the problem is caused by a difference between unzipped and
    installed SM - but I doubt that that can be a reason.

b) Not only Images affected, same problem with ˋInsert → Linkˊ

c) another appearance of 
   "Bug 796994 - Use filepicker's open() instead of the obsolete show() in /suite/*"?
   I don't understand details of bug 1322172
   I will test with 2.55
See Also: → 796994

Comment 3

2 years ago
a4) Still REPRODUCIBLE with unzipped installer of  official en-US SeaMonkey 2.55a1 
   (NT 6.1; WOW64; rv:58.0) Gecko/20100101 Firefox/58.0 Build 20171110010345  
   (Default Classic Theme) on German WIN7 64bit
d) (a4) seems to show that this one is not a DUP of bug 1322172 ?

Currently I don't have time to search for DUPs
OS: Unspecified → All
Assignee

Comment 4

2 years ago
> I don't understand details of bug 1322172

SeaMonkey now saves images as data urls in the mail and news composer. File references relative or not are ignored and/or need to be unblocked. This has likely spilled over to composer but does not make sense here and if this is the cause needs to be fixed for composer only. Try to copy and image from the clipboard and see if this still works.

Bug 796994 has nothing to do with it.
Assignee

Comment 5

2 years ago
Composer is partially broken in 2.55 because of nsIDOM removals. Not all are fixed yet. The problem was reported against 2.49.1 so I would test with this and prior versions only. As far as I know works all fine in 2.48.
See Also: 796994

Comment 6

2 years ago
(In reply to Frank-Rainer Grahl (:frg) from comment #5)
(a2) Was still ok with 2.49a1  20161107002359
     indeed it seems that the problem came up with 2.49.1
Assignee

Comment 7

2 years ago
I overlooked one GetOS() usage when doing bug 1364772. This causes the image properties dialog to fail partially.
Assignee: nobody → frgrahl
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(frgrahl)
See Also: 13221721364772
Assignee

Comment 8

2 years ago
[Approval Request Comment]
Regression caused by (bug #): bug 1364772
User impact if declined: image composition broken.
Testing completed (on m-c, etc.): c-r with 2.53.
Risk to taking this patch (and alternatives if risky): non already broken.
String changes made by this patch: none
Attachment #8930631 - Flags: review?(iann_bugzilla)
Attachment #8930631 - Flags: approval-comm-esr52?
Attachment #8930631 - Flags: approval-comm-beta?
Assignee

Comment 9

2 years ago
Patch for 2.53 (just in case we do a 56 branch).
Assignee

Comment 10

2 years ago
Patch for comm-esr52
Assignee

Comment 11

2 years ago
esr52 patch was bad. Didn't remove a line during rebase.
Attachment #8930635 - Attachment is obsolete: true
Assignee

Updated

2 years ago

Comment 12

2 years ago
Comment on attachment 8930631 [details] [diff] [review]
1417819-imagecomposer.patch

LGTM r/a=me
Attachment #8930631 - Flags: review?(iann_bugzilla)
Attachment #8930631 - Flags: review+
Attachment #8930631 - Flags: approval-comm-esr52?
Attachment #8930631 - Flags: approval-comm-esr52+
Attachment #8930631 - Flags: approval-comm-beta?
Attachment #8930631 - Flags: approval-comm-beta+

Comment 13

2 years ago
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/4424cbfd2136
Replace undefined GetOS() with Appconstants.platform. r=IanN
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Assignee

Updated

2 years ago
Duplicate of this bug: 1420715

Comment 16

2 years ago
Where do I get the fixed version.  Im sorry, I'm new here and Im not understanding exactly how this works.  Will the new version be put on the top page when it's ready??. I had to uninstall, as my Seamonkey really wasn't functioning. This image problem had no go around that I could find. If you drag and drop, the source code is not right. You get a huge long code with no image name. It works on your desktop but no doubt won't work online.  Same problem with the background image. It will work once or twice but as soon as you start working, it will stop working and then you can't change the bg.
Assignee

Updated

2 years ago
Duplicate of this bug: 1418819
Assignee

Comment 18

2 years ago
The new version will be announced on https://www.seamonkey-project.org/

There is no ETA yet. We hope this year but need to fix some other bugs for it first too. If you urgently need a prerelease version send me an email.
Assignee

Updated

2 years ago
Duplicate of this bug: 1424720

Updated

a year ago
Duplicate of this bug: 1427218

Comment 21

a year ago
Sea Monkey opened up with an updated version of 2.49.1 to download. After doing so, nothing changed. Composer still does not work.
Assignee

Comment 22

a year ago
The fix will be in 2.49.2. There is only one 2.49.1. Not sure why you were updated.

Updated

a year ago
Duplicate of this bug: 1428634

Updated

a year ago
Duplicate of this bug: 1430806

Updated

a year ago
Duplicate of this bug: 1437403
You need to log in before you can comment on or make changes to this bug.