1417855 - favicons for suggestions not updating

Status: RESOLVED WORKSFORME

(Toolkit :: Places, defect, P5)

Description

[jayendraminakshisundar]

Attachment: Although I visited each suggested webpage *after clearing the notification*, the notification icon is still used as favicon.

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20171115114231

Steps to reproduce:

Visit a webpage which changes the page icon as a notification. That page should now show up in suggestions from the address bar. 
On a subsequent visit to that page, receive a notification which changes the page icon. Icon on tab should change. Check the notification so the icon changes back.
Begin typing in URL for the page again, and that page shows up as a suggestion. 


Actual results:

The favicon on the suggestion list is sometimes the icon with notification, and sometimes the normal icon, with no relation to whether the notification was cleared or not.


Expected results:

The favicon on the suggestion list should be the most recent icon from that page, reflecting whether the notification was checked.

Comment 1

[Marco Bonardo [:mak]]

it's complicate, because we expire icons after 7 days to avoid excessive I/O, and we have no idea if an icon has been updated as a consequence of a notification or it's the base favicon of the page.
So far I have no idea how we could do this in a performant way, apart from maybe not storing the favicon changes if they happen much after the initial page load. But what if the page immediately uses the notification favicon? It's tricky.

Comment 2

[jayendraminakshisundar]

Could we add a flag or option somewhere to manually expire icons for a certain website?

Comment 3

[Marco Bonardo [:mak]]

Usually it's enough to remove all history and bookmarks for that website to expire its icons.
I don't think we'd be willing to expose an API to Web Content.

Comment 4

[Marco Bonardo [:mak]]

I think we fixed this by ignoring icons set after the "pageshow" event, so this shouldn't happen anymore.