Closed
Bug 1417855
Opened 7 years ago
Closed 4 months ago
favicons for suggestions not updating
Categories
(Toolkit :: Places, defect, P5)
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: jayendraminakshisundar, Unassigned)
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:58.0) Gecko/20100101 Firefox/58.0 Build ID: 20171115114231 Steps to reproduce: Visit a webpage which changes the page icon as a notification. That page should now show up in suggestions from the address bar. On a subsequent visit to that page, receive a notification which changes the page icon. Icon on tab should change. Check the notification so the icon changes back. Begin typing in URL for the page again, and that page shows up as a suggestion. Actual results: The favicon on the suggestion list is sometimes the icon with notification, and sometimes the normal icon, with no relation to whether the notification was cleared or not. Expected results: The favicon on the suggestion list should be the most recent icon from that page, reflecting whether the notification was checked.
Updated•7 years ago
|
Component: Untriaged → Places
Product: Firefox → Toolkit
Comment 1•7 years ago
|
||
it's complicate, because we expire icons after 7 days to avoid excessive I/O, and we have no idea if an icon has been updated as a consequence of a notification or it's the base favicon of the page. So far I have no idea how we could do this in a performant way, apart from maybe not storing the favicon changes if they happen much after the initial page load. But what if the page immediately uses the notification favicon? It's tricky.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P5
Reporter | ||
Comment 2•7 years ago
|
||
Could we add a flag or option somewhere to manually expire icons for a certain website?
Comment 3•7 years ago
|
||
Usually it's enough to remove all history and bookmarks for that website to expire its icons. I don't think we'd be willing to expose an API to Web Content.
Updated•2 years ago
|
Severity: normal → S3
Comment 4•4 months ago
|
||
I think we fixed this by ignoring icons set after the "pageshow" event, so this shouldn't happen anymore.
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•