1417906 - Convert mozcrash test to pytest format

Status: RESOLVED DUPLICATE of bug 1441287

(Testing :: Mozbase, enhancement)

Description

[Andrew Halberstadt [:ahal]]

See bug 1397417 for the tracking bug with motivations for this change.

Here is the pytest documentation:
https://docs.pytest.org/en/latest/contents.html

That is a lot of information, but this bug is basically about modifying 'testing/mozbase/mozcrash/tests/test.py' to make better use of pytest (it is already running under pytest, but is structured as a unittest test).

This means:

1. Use 'assert foo == bar' instead of self.assertEquals(foo, bar)
2. Use module level test functions instead of unittest.TestCase based classes
3. Replace the setUp/tearDown/popen_factory stuff with a fixture. More information on how fixtures work can be found here:
https://docs.pytest.org/en/latest/fixture.html

Changes can be tested with:
./mach python-test testing/mozbase/mozcrash
./mach lint testing/mozbase/mozcrash

Or on try with:
./mach try fuzzy -q "'mozbase"

(or leave off the -q to choose it in the selection interface)

Comment 1

[icebrr79]

Hello,  

I'm 100% interested and excited to get started on this bug.

Comment 2

[Andrew Halberstadt [:ahal]]

Thanks icebrr79! Hopefully there's enough information here and in my comment on the other bug to get you started. But if not, please feel free to ask questions either here, or send me an e-mail. You can also join #ateam on irc.mozilla.org if you like (I'm ahal).

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This has actually been done meanwhile via bug 1441287.