Open Bug 1417935 Opened 7 years ago Updated 3 years ago

Look into removing AB_CD from ACDEFINES by default

Categories

(Firefox Build System :: General, enhancement)

Product:
Firefox Build System
Component:
General
Type:
enhancement

Tracking

(Not tracked)

People

(Reporter: ted, Unassigned)

References

Details

While writing the patches for bug 1409721, I realized that config.mk puts `AB_CD` in `DEFINES`: https://searchfox.org/mozilla-central/rev/a662f122c37704456457a526af90db4e3c0fd10e/config/config.mk#366 This is used by preprocessed entries in jar manifests as well as things in `PP_TARGETS`, which include `FINAL_TARGET_PP_FILES` as well as my new `LOCALIZED_PP_FILES`. However, actually using that define in a file in `FINAL_TARGET_PP_FILES` would be a mistake, as the file wouldn't actually get localized and the 'en-US' value would wind up in localized builds. We could fix this by taking it out of `ACDEFINES` and having the other locations explicitly add it in to their list of preprocessor defines.
Product: Core → Firefox Build System
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.