Closed Bug 1417989 Opened 7 years ago Closed 7 years ago

stackwalker no longer producing loaded symbol paths in output

Categories

(Socorro :: Processor, task, P1)

Product:
Socorro
Component:
Processor
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ted, Assigned: ted)

References

Details

bug 1187852 seems to have regressed at some point. The stackwalker should be putting a "symbol_url" field for modules where we loaded symbols, but it's not: https://github.com/mozilla-services/socorro/blob/6699bcdc3f5ed1c6a566a9d875ba87fc3463b0e0/minidump-stackwalk/stackwalker.cc#L596 The report/index page will generate links to that URL on the Modules tab, and I noticed they were missing. Here's a recent crash, processed 2017-11-16 where we definitely loaded symbols for xul.dll: https://crash-stats.mozilla.com/report/index/b9fbbb0a-03df-42c3-8afa-3f5ee0171116#tab-rawdump the entry in the modules list in the raw dump shows: { "base_addr": "0xf7e0000", "code_id": "5A08599138cd000", "debug_file": "xul.pdb", "debug_id": "3EAC05EF68354302A178E9AF50F214FF2", "end_addr": "0x130ad000", "filename": "xul.dll", "version": "57.0.0.6525" }, Compare vs. an arbitrary crash report from my local machine, processed 2017-10-05: https://crash-stats.mozilla.com/report/index/bdacddb5-a7aa-47bb-ad74-2666c0171005#tab-rawdump which has: { "base_addr": "0x7ff8a1420000", "code_id": "59D572364834000", "debug_file": "xul.pdb", "debug_id": "F8603BA23173418B9CA4657E2EEB97A12", "end_addr": "0x7ff8a5c54000", "filename": "xul.dll", "loaded_symbols": true, "symbol_disk_cache_hit": true, "symbol_url": "https://s3-us-west-2.amazonaws.com/org.mozilla.crash-stats.symbols-public/v1/xul.pdb/F8603BA23173418B9CA4657E2EEB97A12/xul.sym", "version": "58.0.0.6486" }, So it broke in roughly the last month. Seems possible that it broke in bug 1400952?
Making this a P1 because it's a regression that impacts individual crash analysis.
Priority: -- → P1
Assignee: nobody → ted
This was a regression from bug 1400952, I totally missed that. https://github.com/mozilla-services/socorro/pull/4404
Blocks: 1400952
Commits pushed to master at https://github.com/mozilla-services/socorro https://github.com/mozilla-services/socorro/commit/31c7ad0c3bf96e06cf7b15f9e33274420f8da087 bug 1417989 - fix method signature of StackFrameSymbolizerForward::FillSourceLineInfo When Breakpad was updated to the most recent snapshot the signature of this method in the base class changed, but we didn't update our implementation to match, so our overload was not being called. https://github.com/mozilla-services/socorro/commit/51ee5b8d0481aa9f323bd43c775f4bfcfa551681 Merge branch 'master' into bug1417989 https://github.com/mozilla-services/socorro/commit/982c08bfc5d93682757f03d0c6f47264528ae1bf Merge pull request #4404 from luser/bug1417989 bug 1417989 - fix method signature of StackFrameSymbolizerForward::FillSourceLineInfo
Ted said that PR 4404 fixes it, so I'm marking this as FIXED.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.