1418026 - Remove unused code from js/src/frontend

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P2)

Comment 1

[André Bargull [:anba]]

Attachment: bug1418026.patch

Removes some unused functions from js/src/frontend and additionally:

FullParseHandler.h
- Inlined lazyOuterFunction() getter to directly access the class field.

SyntaxParseHandler.h
- Inlined isUnparenthesizedName() into its sole caller isNameAnyParentheses().

telemetry/Histograms.json
- Added "(obsolete)" comment to all unused entries.

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8929118 [details] [diff] [review]
bug1418026.patch

Review of attachment 8929118 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

::: js/src/frontend/LanguageExtensions.h
@@ +28,2 @@
>      // NO LONGER USING 2
>      ExpressionClosure = 3, // Added in JS 1.8

Ah the last one - we've come a long way :)

Comment 3

[André Bargull [:anba]]

(In reply to Jan de Mooij [:jandem] from comment #2)
> ::: js/src/frontend/LanguageExtensions.h
> @@ +28,2 @@
> >      // NO LONGER USING 2
> >      ExpressionClosure = 3, // Added in JS 1.8
> 
> Ah the last one - we've come a long way :)

Yeah, totally! :-)

Comment 4

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d904fa1e7ba6229d505057cde27a21d1a5d2bfad

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/65629d4e9531
Remove unused code from js/src/frontend. r=jandem

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/65629d4e9531