Closed
Bug 1418026
Opened 4 years ago
Closed 3 years ago
Remove unused code from js/src/frontend
Categories
(Core :: JavaScript Engine, enhancement, P2)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
References
Details
Attachments
(1 file)
19.18 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•4 years ago
|
||
Removes some unused functions from js/src/frontend and additionally: FullParseHandler.h - Inlined lazyOuterFunction() getter to directly access the class field. SyntaxParseHandler.h - Inlined isUnparenthesizedName() into its sole caller isNameAnyParentheses(). telemetry/Histograms.json - Added "(obsolete)" comment to all unused entries.
Attachment #8929118 -
Flags: review?(jdemooij)
Comment 2•4 years ago
|
||
Comment on attachment 8929118 [details] [diff] [review] bug1418026.patch Review of attachment 8929118 [details] [diff] [review]: ----------------------------------------------------------------- Nice. ::: js/src/frontend/LanguageExtensions.h @@ +28,2 @@ > // NO LONGER USING 2 > ExpressionClosure = 3, // Added in JS 1.8 Ah the last one - we've come a long way :)
Attachment #8929118 -
Flags: review?(jdemooij) → review+
Assignee | ||
Comment 3•4 years ago
|
||
(In reply to Jan de Mooij [:jandem] from comment #2) > ::: js/src/frontend/LanguageExtensions.h > @@ +28,2 @@ > > // NO LONGER USING 2 > > ExpressionClosure = 3, // Added in JS 1.8 > > Ah the last one - we've come a long way :) Yeah, totally! :-)
Assignee | ||
Comment 4•4 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d904fa1e7ba6229d505057cde27a21d1a5d2bfad
Keywords: checkin-needed
Pushed by apavel@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/65629d4e9531 Remove unused code from js/src/frontend. r=jandem
Keywords: checkin-needed
Updated•3 years ago
|
Priority: -- → P2
Comment 6•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/65629d4e9531
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•