Closed
Bug 1418079
Opened 8 years ago
Closed 8 years ago
Check for leaks in ContentBlocker swift
Categories
(Firefox for iOS :: General, enhancement)
Tracking
()
RESOLVED
WONTFIX
| Tracking | Status | |
|---|---|---|
| fxios | ? | --- |
People
(Reporter: garvan, Assigned: garvan)
Details
we're leaking a `Deferred<Void>`: https://github.com/mozilla-mobile/firefox-ios/blob/master/Client/Frontend/ContentBlocker/ContentBlockerHelper.swift#L320
Make sure all code paths fill the deferred.
Also look at https://github.com/mozilla-mobile/firefox-ios/blob/master/Client/Frontend/ContentBlocker/ContentBlockerHelper.swift#L258
All usages of Deferred.any() are reported as leaks. We should update our Deferred. The version we have reports leaks using any, and reading the source it isn't clear to me how it would avoid that.
The current upstream version of Deferred I don't see that it would cause the same problem -from reading the source- it very clearly calls DispatchGroup.leave(), which is required for non-leaky DispatchGroup.
Wont fix, it is a side effect of our choice of Deferred lib.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•