1418087 - Graphics driver block request: 0x1002 driver less than 21.19.411.0 for GPU_PROCESS on All (Windows)

Status: RESOLVED WONTFIX

(Toolkit :: Blocklist Policy Requests, enhancement)

Description

[Milan Sreckovic [:milan] (needinfo for best results)]

OS: All Windows (so, "All")
Vendor: 0x1002
Devices: All
Feature: GPU_PROCESS
Feature status: BLOCKED_DRIVER_VERSION
Driver version: 21.19.411.0
Driver version comparator: LESS_THAN
Firefox versions: 57.0 only

Contact info: :milan
Reasons: See bug 1417442

This is the actual entry we want:

<gfxBlacklistEntry>
  <os>All</os>
  <vendor>0x1002</vendor>
  <feature>GPU_PROCESS</feature>
  <featureStatus>BLOCKED_DRIVER_VERSION</featureStatus>
  <driverVersion>21.19.411.0</driverVersion>
  <driverVersionComparator>LESS_THAN</driverVersionComparator>
  <versionRange minVersion="57.0" maxVersion="57.0"/>
</gfxBlacklistEntry>

Comment 1

[Rémy Hubscher (:natim)]

I know that Jorge already told me that your team doesn't want to be held responsible for that blocklist anymore but since currently you are the only one being able to do the change, could one of you create the record in settings-writer.prod.mozaws.net and someone else review it?

Thanks.

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

For the background, this is 57 release video issue with 50k+ people affected so far.

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

Milan, can you confirm <feature>GPU_PROCESS</feature>?

I'm looking at the available options in the blocklisting UI and I don't see that one. Maybe it's a recent one that hasn't been added, in which case we'll need to make a code change before we can enter the blocklist entry.

Comment 4

[Rémy Hubscher (:natim)]

> GPU_PROCESS

If that's a valid feature we can add it in the JSONSchema.

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

Let's assume the report is correct and add it to the schema.

Comment 6

[Rémy Hubscher (:natim)]

Attachment: PR #2 ­— Add new GFX feature

Comment 7

[Milan Sreckovic [:milan] (needinfo for best results)]

Yes, GPU_PROCESS is a valid feature since version 52.  The older versions will ignore it.

Comment 8

[Jorge Villalobos [:jorgev] (he/him)]

Comment on attachment 8929551 [details] [review]
PR #2 ­— Add new GFX feature

Also reviewed on GitHub.

Comment 9

[Jason Thomas [:jason]]

The changes in comment 6 have been deployed to stage and prod.

Comment 10

[Jorge Villalobos [:jorgev] (he/him)]

Milan, the block should now be staged and ready for testing. Let me know when it's okay to push it live.

Comment 11

[Milan Sreckovic [:milan] (needinfo for best results)]

I'm testing, but may have discovered a bug that would make this change be ignored.  So, no point in going live until we know for sure.

Comment 12

[Rémy Hubscher (:natim)]

I can confirm that the block item is available here: https://firefox.settings.services.mozilla.com/v1/preview/3/%7Bec8030f7-c20a-464f-9b0e-13a3a9e97384%7D/57.0/

Comment 13

[Mathieu Leplatre [:leplatrem]]

According to this code, the GPU_PROCESS feature value is not supported:
https://dxr.mozilla.org/mozilla-central/rev/b056526be38e96b3e381b7e90cd8254ad1d96d9d/widget/GfxInfoBase.cpp#324

Comment 14

[Milan Sreckovic [:milan] (needinfo for best results)]

We only have partial support for this, so it never gets parsed out of the blocklist.  That will get addressed in bug 1418980, in the meantime we do not need this bug.

Comment 15

[Jorge Villalobos [:jorgev] (he/him)]

Just FYI, I removed the staged block.