1418107 - Bad Naming on KeyType for rsaperf tool

Status: RESOLVED DUPLICATE of bug 1309068

(NSS :: Libraries, defect)

Description

[Nick Gonella]

Attachment: Wshadow.patch

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20171116100106

Steps to reproduce:

I added code which enabled Wshadow on builds as part of working on bug 1309068. I've included a patch to enable Wshadow in the build.


Actual results:

In `lib/cryptohi/keythi.h`, the enum `KeyType` has the value `rsaKey` as one of it's enum values. This causes a warning under Wshadow with `cmd/rsaperf/rsaperf.c`, which also uses the indentifier `rsaKey` as a variable.


Expected results:

All the values for an `extern` enum such as `KeyType`, including `rsaKey`, should have some kind of name-spacing prefix on them. My proposal would be specifically for them to be `KEYTYPE_RSAKEY`. This way, we wouldn't have to worry about shadowing random local variable with an enum type.

Comment 1

[Franziskus Kiefer [:franziskus]]

wshadow is enabled by default now.