Closed Bug 1418130 Opened 2 years ago Closed 2 years ago

Fix favicon link, default tippytop and bug fixes to Activity Stream

Categories

(Firefox :: New Tab Page, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 59
Tracking Status
firefox57 --- wontfix
firefox58 --- wontfix
firefox59 --- fixed

People

(Reporter: dmose, Assigned: Mardak)

References

Details

(Whiteboard: [export])

User Story

https://github.com/mozilla/activity-stream/compare/6fcebaca989a6a4ab81ab0d717f5060e39def2ca...dc9d0c0e4345663b651b1214cdc1ee10ba2d5efe

Attachments

(3 files)

This is a bug intended to be used for the _next_ export to github.  

That export will include the new "prop-types" package and license, as that package contains code that was original part of React, and is now split out into its own MIT-licensed package (see https://github.com/mozilla/activity-stream/issues/3836 and the associated pull request for details).

I'm going to attache the necessary license.html patch to this bug and get it reviewed now, so that it can be landed with the next uplift.
Comment on attachment 8929234 [details]
Bug 1418130 - add prop-types license and remove activity-stream from list of reselect license users,

https://reviewboard.mozilla.org/r/200506/#review205660
Attachment #8929234 - Flags: review?(gerv) → review+
User Story: (updated)
Depends on: 1415812
[Tracking Requested - why for this release]: this needs to be included in next 58 beta uplift
Priority: -- → P1
Depends on: 1417943
Depends on: 1400585
Depends on: 1421417
No longer depends on: 1400585, 1415812, 1417943, 1421417
Summary: next activity-stream export from github (after bug 1415812) → export from github with react 16
Summary: export from github with react 16 → export from github with (at least) new proptypes
Assignee: nobody → edilee
User Story: (updated)
Summary: export from github with (at least) new proptypes → Fix tippytop site_icons, favicon link and bug fixes to Activity Stream
Like the previous export, this does not include https://github.com/mozilla/activity-stream/pull/3875 as it's still pending data review in https://github.com/mozilla/activity-stream/pull/3877
Meh.

gerv, sorry about the re-request-r? MozReview couldn't associate the two commits together, so I had to re-push, and it isn't smart enough to carry over your r+ for attachment 8929234 [details]
Attachment #8935569 - Flags: review?(gerv) → review+
User Story: (updated)
Summary: Fix tippytop site_icons, favicon link and bug fixes to Activity Stream → Fix favicon link, default tippytop and bug fixes to Activity Stream
wow.. mozreview...
Updated with bug 1424292 and bug 1423506 landing separately as those are potentially for 58 uplift.
Depends on: 1424292
Attachment #8935569 - Flags: review?(gerv) → review+
Comment on attachment 8935548 [details]
Bug 1418130 - Fix favicon link, default tippytop and bug fixes to Activity Stream.

https://reviewboard.mozilla.org/r/206422/#review213012

Looks good
Attachment #8935548 - Flags: review?(khudson) → review+
Pushed by edilee@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/75910829e890
Fix favicon link, default tippytop and bug fixes to Activity Stream. r=k88hudson
https://hg.mozilla.org/integration/mozilla-inbound/rev/28f5404cc95e
add prop-types license and remove activity-stream from list of reselect license users, r=gerv
https://hg.mozilla.org/mozilla-central/rev/75910829e890
https://hg.mozilla.org/mozilla-central/rev/28f5404cc95e
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Blocks: 1426203
Depends on: 1426916
Depends on: 1427031
Whiteboard: [export]
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.