Closed Bug 1418135 Opened 4 years ago Closed 4 years ago
asynchronously determine the certificate chain to display in the details pane of the certificate viewer
bug 1418135 - asynchronously determine the chain to display in the details pane of the certificate viewer
59 bytes, text/x-review-board-request
The current certificate viewer uses "getChain" to determine what chain to show in the details pane. This is problematic for a number of reasons including a) it's synchronous (and potentially slow) and b) getChain may return something almost entirely quite unlike any actual trusted path. This won't fix the whole problem (whatever's opening the certificate viewer should really be passing in the chain itself), but that's hard, so this would at least change the determination to be asynchronous and at least won't result in something completely bogus.
Oh and this may fix bug 1409910.
4 years ago
Comment on attachment 8929244 [details] bug 1418135 - asynchronously determine the chain to display in the details pane of the certificate viewer https://reviewboard.mozilla.org/r/200518/#review206038
Attachment #8929244 - Flags: review?(mgoodwin) → review+
Thanks! Had to fix up some eslint issues, but otherwise looks good to go: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f350539f454f
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/64a8c43f5b9c asynchronously determine the chain to display in the details pane of the certificate viewer r=mgoodwin
Hmmm looks like it didn't fix bug 1409910: https://public-artifacts.taskcluster.net/D8dMnVEmTNGabMfdAlz8EQ/0/public/logs/live_backing.log It's still an improvement, anyway.
You need to log in before you can comment on or make changes to this bug.