Closed
Bug 1418141
Opened 7 years ago
Closed 7 years ago
Refactor windows taskcluster configs.
Categories
(Release Engineering :: Applications: MozharnessCore, enhancement)
Release Engineering
Applications: MozharnessCore
Tracking
(firefox59 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: tomprince, Assigned: tomprince)
Details
Attachments
(3 files)
There is a lot of needless duplication in the mozharness configs used for windows builds on taskcluster.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•7 years ago
|
||
39 files changed, 293 insertions(+), 1200 deletions(-)
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8929241 [details] Bug 1418141: Combine taskcluster win32 mozharness configs. https://reviewboard.mozilla.org/r/200510/#review207158 ::: testing/mozharness/mozharness/base/config.py:497 (Diff revision 1) > self.all_cfg_files_and_dicts.extend(self.get_cfgs_from_files( > # append opt_config to allow them to overwrite previous configs > options.config_files + options.opt_config_files, options=options > )) > config = {} > - if self.append_env_variables_from_configs: > + if (self.append_env_variables_from_configs nice!
Attachment #8929241 -
Flags: review?(jlund) → review+
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8929242 [details] Bug 1418141: Combine taskcluster win64 mozharness configs. https://reviewboard.mozilla.org/r/200512/#review207166 ::: taskcluster/ci/build/windows.yml:477 (Diff revision 1) > using: mozharness > script: mozharness/scripts/fx_desktop_build.py > config: > - builds/releng_base_firefox.py > - - builds/taskcluster_firefox_win64_ccov_debug.py > + - builds/taskcluster_base_win64.py > + - builds/taskcluster_sub_win64/ccov_debug.py missing option append-env-variables-from-configs ?
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8929243 [details] Bug 1418141: Combine taskcluster win base configs. https://reviewboard.mozilla.org/r/200514/#review207190
Attachment #8929243 -
Flags: review?(jlund) → review+
Assignee | ||
Comment 8•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8929242 [details] Bug 1418141: Combine taskcluster win64 mozharness configs. https://reviewboard.mozilla.org/r/200512/#review207166 > missing option append-env-variables-from-configs ? Yeah. Fixed. This was the one windows builder added between when I first wrote these patches and now.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 12•7 years ago
|
||
mozreview-review |
Comment on attachment 8929242 [details] Bug 1418141: Combine taskcluster win64 mozharness configs. https://reviewboard.mozilla.org/r/200512/#review207930
Attachment #8929242 -
Flags: review?(jlund) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 19•7 years ago
|
||
Pushed by mozilla@hocat.ca: https://hg.mozilla.org/integration/autoland/rev/01b97ef0de10 Combine taskcluster win32 mozharness configs. r=jlund https://hg.mozilla.org/integration/autoland/rev/68e180048ca9 Combine taskcluster win64 mozharness configs. r=jlund https://hg.mozilla.org/integration/autoland/rev/6cd9206792f9 Combine taskcluster win base configs. r=jlund
Comment 20•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/01b97ef0de10 https://hg.mozilla.org/mozilla-central/rev/68e180048ca9 https://hg.mozilla.org/mozilla-central/rev/6cd9206792f9
Comment 21•7 years ago
|
||
Backed out 3 changesets (bug 1418141) for breaking Windows DMD builds r=backout a=backout https://hg.mozilla.org/mozilla-central/rev/c15f17881cd5dec9d58c84551e9d0bfd2d1f4820 Failure push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=f2e36fbb90fad27c034105709a4cbbaef9bd58c8
Status: RESOLVED → REOPENED
status-firefox59:
fixed → ---
Flags: needinfo?(mozilla)
Resolution: FIXED → ---
Comment 22•7 years ago
|
||
Pushed by mozilla@hocat.ca: https://hg.mozilla.org/integration/autoland/rev/3d83ffab30dc Combine taskcluster win32 mozharness configs. r=jlund https://hg.mozilla.org/integration/autoland/rev/599b59f91c1c Combine taskcluster win64 mozharness configs. r=jlund https://hg.mozilla.org/integration/autoland/rev/494839119203 Combine taskcluster win base configs. r=jlund
Comment 23•7 years ago
|
||
Backed out 3 changesets (bug 1418141) as requested by developer r=backout https://hg.mozilla.org/integration/autoland/rev/fe79e11933098fa264a1c258f5ca0fe6699f9058 https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=494839119203743f5914aef570c44a676c6cc815&filter-classifiedState=unclassified&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 27•7 years ago
|
||
mozreview-review |
Comment on attachment 8929243 [details] Bug 1418141: Combine taskcluster win base configs. https://reviewboard.mozilla.org/r/200514/#review208680
Comment 28•7 years ago
|
||
Pushed by mozilla@hocat.ca: https://hg.mozilla.org/integration/autoland/rev/336caac0487f Combine taskcluster win32 mozharness configs. r=jlund https://hg.mozilla.org/integration/autoland/rev/7e67e0f63dfd Combine taskcluster win64 mozharness configs. r=jlund https://hg.mozilla.org/integration/autoland/rev/343c49198f19 Combine taskcluster win base configs. r=jlund
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(mozilla)
Comment 29•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/336caac0487f https://hg.mozilla.org/mozilla-central/rev/7e67e0f63dfd https://hg.mozilla.org/mozilla-central/rev/343c49198f19
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•