Closed Bug 1418158 Opened 7 years ago Closed 6 years ago

Import of Custom Elements (v1) Polyfill

Categories

(mozilla.org :: Licensing, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: MattN, Assigned: gerv)

References

()

Details

Attachments

(1 file)

I would like to import the Custom Elements (v1) Polyfill from https://github.com/webcomponents/custom-elements/blob/v1.0.5/custom-elements.min.js for use until Firefox's Custom Elements implementation is stable.

License file: https://github.com/webcomponents/custom-elements/blob/v1.0.5/LICENSE.md

Header inside the file: https://github.com/webcomponents/custom-elements/blob/v1.0.5/custom-elements.min.js#L27-L32

Is my license.html change at https://reviewboard.mozilla.org/r/200056/diff/1#file5783094 sufficient?
(In reply to Matthew N. [:MattN] (PM if requests are blocking you) from comment #0)
> Is my license.html change at
> https://reviewboard.mozilla.org/r/200056/diff/1#file5783094 sufficient?

Unfortunately not, because the copyright line is different. You'll need to add a new block :-|

Gerv
OK, I've added a Polymer section with the contents of http://polymer.github.io/LICENSE.txt

I do wonder if I need to include the contents of the header inside the file too: https://github.com/webcomponents/custom-elements/blob/v1.0.5/custom-elements.min.js#L27-L32

and/or if I need to include copyright lines since the year and work "Project" differ:

> Copyright (c) 2014 The Polymer Authors. All rights reserved.
> Copyright (c) 2016 The Polymer Project Authors. All rights reserved.
Attachment #8929285 - Flags: review?(gerv)
No, just include the LICENSE.txt file.

But also, we shouldn't be putting minified-code-only into our repo. Please check the unminified version in alongside, even if we don't reference it in the build, and make sure the text in the license block reflects that. You should probably put the two files in their own subdirectory, with a copy of LICENSE.txt.

Gerv
Attachment #8929285 - Flags: review?(gerv) → review-
We removed the polyfill in bug 1496698.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: