1418164 - ###!!! ASSERTION: writer returned an error with non-zero writeCount

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

STR:
1. Start with --jsdebugger --wait-for-jsdebugger

On startup, I get:

[Parent 63564, Main Thread] ###!!! ASSERTION: writer returned an error with non-zero writeCount: '(NS_FAILED(rv) ? (*aWriteCount == 0) : true)', file /Users/mrbkap/work/main/mozilla/xpcom/io/nsInputStreamTee.cpp, line 206

This is because:

(lldb) p tee->mWriter
(nsWriteSegmentFun) $1 = 0x0000000101654590 (XUL`TestInputStream(nsIInputStream*, void*, char const*, unsigned int, unsigned int, unsigned int*) at nsStreamUtils.cpp:744)

doesn't touch aWriteCount. That's easy enough to fix.

I don't think this affects non-debug builds.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Bug 1418164 - Don't leave uninitialized values lying around.

The users of WriteSegmentFun and ReadSegmentFun read the final out parameter
whether or not the function returns an error. We should make sure to fill it
in with a sane value.

Review commit: https://reviewboard.mozilla.org/r/200580/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200580/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8929276 [details]
Bug 1418164 - Don't leave uninitialized values lying around.

https://reviewboard.mozilla.org/r/200580/#review205704

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b34457e29b87
Don't leave uninitialized values lying around. r=froydnj

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b34457e29b87