1418184 - Use BrowserTestUtils.waitForEvent in browser/components/sessionstore/test/

Status: RESOLVED FIXED

(Firefox :: General, defect, P3)

Description

[Tooru Fujisawa [:arai]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc35b181a4a55c0bd3cca8a19346ff224545a649&selectedJob=143221643
> FAIL | browser/components/sessionstore/test/browser_crashedTabs.js | Should have closed the tab 

it's because of the TabClose event is fired and the promise gets resolved before the tab actually gets closed.
it should wait for the tab gets closed.
then, in bug 1416446, I'm going to make BrowserTestUtils.waitForEvent to do so, and the promiseEvent in browser/components/sessionstore/test/head.js can be replaced with it.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Use BrowserTestUtils.waitForEvent in browser/components/sessionstore/test/.

I'll ask review after bug 1416446 (since this patch highly depends on the behavior changed there

Comment 2

[Tooru Fujisawa [:arai]]

Comment on attachment 8929708 [details] [diff] [review]
Use BrowserTestUtils.waitForEvent in browser/components/sessionstore/test/.

after bug 1193394, the test needs to wait for the next event tick after each event handler gets called, before proceeding to the remaining part.
because otherwise the remaining part will be executed too early, compared to current behavior, and UI etc is not yet ready.

then, BrowserTestUtils.waitForEvent is going to be modified to do so, in bug 1416153.
so, instead of modifying promiseEvent, I changed those consumers to use BrowserTestUtils.waitForEvent.

Comment 3

[Tooru Fujisawa [:arai]]

(In reply to Tooru Fujisawa [:arai] from comment #2)
> then, BrowserTestUtils.waitForEvent is going to be modified to do so, in bug
> 1416153.
> so, instead of modifying promiseEvent, I changed those consumers to use
> BrowserTestUtils.waitForEvent.

sorry, I pointed wrong bug.
it's bug 1416446, not bug 1416153.

Comment 4

[Mike Taylor [:miketaylr]]

arai, wanna land this?

Comment 5

[Tooru Fujisawa [:arai]]

sorry, I forgot to update dependency.
it's also blocked by bug 1421113 (the last patch there)
I'll land this once those gets fixed.

Comment 6

[Tooru Fujisawa [:arai]]

moved the patch to bug 1424074.

Comment 7

[Mike Taylor [:miketaylr]]

Cool, thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/935dcd1ea40c
Use BrowserTestUtils.waitForEvent in browser/components/sessionstore/test/. r=felipe

Comment 9

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/935dcd1ea40cb1b32a1bca067a3e8f422fa8fbef
Bug 1418184 - Use BrowserTestUtils.waitForEvent in browser/components/sessionstore/test/. r=felipe

Comment 10

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/847ed3d5357c
Backed out changeset 935dcd1ea40c for failing browser-chrome's browser/base/content/test/permissions/browser_temporary_permissions_expiry.js on Windows 7 debug without e10s  r=backout on a CLOSED TREE

Comment 11

[Andreea Pavel [:apavel]]

Backed out changeset 56343b0de5c2 (bug 1424083) for failing browser-chrome's browser/base/content/test/permissions/browser_temporary_permissions_expiry.js on Windows 7 debug without e10s r=backout on a CLOSED TREE 

Failure push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=1c819b56fe973b077d64737db186b066850e1197

Failure log: https://hg.mozilla.org/integration/mozilla-inbound/rev/a73f5a62f971efb9afa3b2e70b5d01b447ba3ed3

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/847ed3d5357c6120f39c27b9198550c222b4d2b1

Comment 12

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8d1a1a8c9a420279e3b667bef15ebf863ccf556d
Bug 1418184 - Use BrowserTestUtils.waitForEvent in browser/components/sessionstore/test/. r=felipe

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8d1a1a8c9a42