Closed Bug 1418187 Opened 3 years ago Closed 3 years ago

Text overlaps search box icon in synced tabs sidebar

Categories

(Firefox :: Theme, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Firefox 59
Tracking Status
firefox-esr52 --- unaffected
firefox57 --- unaffected
firefox58 --- unaffected
firefox59 --- fixed

People

(Reporter: magicp.jp, Assigned: daleharvey)

References

Details

(Keywords: regression)

Attachments

(2 files)

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0 ID:20171116220410

Steps to reproduce:
1. Launch the latest Nightly build (20171116220410)on Windows or Ubuntu
2. Open synced tabs sidebar
3. Enter any text until overflow in search box

Actual Results:
Text overlaps search box icon.

Expected Results:
No overlap.
Dale, can you take a look please?
Flags: needinfo?(dharvey)
Keywords: regression
Priority: -- → P2
Weird will do
Assignee: nobody → dharvey
Flags: needinfo?(dharvey)
Yup that is just how text-index behaves, the actual |input| doesnt respond to padding for some reason but there are 2 containers in the input that work fine for having the background
Comment on attachment 8930125 [details]
Bug 1418187 - Ensure text doesnt overlay icon when overflowing.

https://reviewboard.mozilla.org/r/201296/#review206850

Thanks!
Attachment #8930125 - Flags: review?(dao+bmo) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/87d22090c976
Ensure text doesnt overlay icon when overflowing. r=dao
https://hg.mozilla.org/mozilla-central/rev/87d22090c976
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
You need to log in before you can comment on or make changes to this bug.