Closed Bug 1418191 Opened 7 years ago Closed 7 years ago

Should not send the CTA telemetry event ping when tours have no CTA button

Categories

(Firefox :: Tours, defect, P1)

Product:
Firefox
Component:
Tours
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 59
Tracking Flags:
Tracking Status
firefox57 --- wontfix
firefox58 --- fixed
firefox59 --- fixed

People

(Reporter: Fischer, Assigned: gasolin)

References

Details

(Whiteboard: [onboarding-telemetry] )

Attachments

(1 file)

Bug 1418191 - not send the CTA telemetry event ping when instant complete;
59 bytes, text/x-review-board-request
Fischer
: review+
gchang
: approval-mozilla-beta+
Details
For tours, such as Performance, without the CTA button, we shouldn't send the CTA ping. However, we do that right now. Should correct that.
QA Whiteboard: [onboarding-telemetry]
status-firefox57: --- → wontfix
status-firefox58: --- → affected
status-firefox59: --- → affected
Priority: -- → P1
QA Whiteboard: [onboarding-telemetry]
Whiteboard: [onboarding-telemetry]
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
Comment on attachment 8929969 [details] Bug 1418191 - not send the CTA telemetry event ping when instant complete; https://reviewboard.mozilla.org/r/201136/#review206636 ::: browser/extensions/onboarding/content/onboarding.js:37 (Diff revision 4) > * // The unique tour id > * id: "onboarding-tour-addons", > * // (optional) mark tour as complete instantly when the user enters the tour > * instantComplete: false, > + * // (optional) note this tour does not need send CTA telemetry when instant complete > + * instantCtaTelemetry: false, Why need this? No CTA so no CTA event. Simply removing the wrong ping shuld be enough.
Attachment #8929969 - Flags: review?(fliu)
Comment on attachment 8929969 [details] Bug 1418191 - not send the CTA telemetry event ping when instant complete; https://reviewboard.mozilla.org/r/201136/#review206672 ::: browser/extensions/onboarding/content/onboarding.js:37 (Diff revision 4) > * // The unique tour id > * id: "onboarding-tour-addons", > * // (optional) mark tour as complete instantly when the user enters the tour > * instantComplete: false, > + * // (optional) note this tour does not need send CTA telemetry when instant complete > + * instantCtaTelemetry: false, ok, removed cta-click event for instantComplete case
Comment on attachment 8929969 [details] Bug 1418191 - not send the CTA telemetry event ping when instant complete; https://reviewboard.mozilla.org/r/201136/#review207246
Attachment #8929969 - Flags: review?(fliu) → review+
Pushed by flin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5378dcb45044 not send the CTA telemetry event ping when instant complete;r=Fischer
https://hg.mozilla.org/mozilla-central/rev/5378dcb45044
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox59: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Comment on attachment 8929969 [details] Bug 1418191 - not send the CTA telemetry event ping when instant complete; Approval Request Comment [Feature/Bug causing the regression]: Bug 1389424 [User impact if declined]: the change does not affect the user, but collect unwanted telemetry data makes dashboard inaccurate [Is this code covered by automated tests?]: N [Has the fix been verified in Nightly?]: manual test to ensure the telemetry is gone [Needs manual test from QE? If yes, steps to reproduce]: N [List of other uplifts needed for the feature/fix]: N [Is the change risky?]: N [Why is the change risky/not risky?]: Remove one of existing telemetry ping should not cause issue [String changes made/needed]: N
Attachment #8929969 - Flags: approval-mozilla-beta?
Comment on attachment 8929969 [details] Bug 1418191 - not send the CTA telemetry event ping when instant complete; Remove a telemetry ping. Should be low risk. Beta58+.
Attachment #8929969 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: