1418195 - Baldr: make ToNonWrappingUint32 throw on NaN

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[Luke Wagner [:luke]]

This follows from the use of WebIDL's [EnforceRange] in https://github.com/WebAssembly/spec/pull/591 as opposed to the ad hoc ToNonWrappingUint32() in the informal JS.md (https://github.com/WebAssembly/design/blob/master/JS.md#tononwrappinguint32).

Comment 1

[Luke Wagner [:luke]]

Attachment: enforce-range

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8930261 [details] [diff] [review]
enforce-range

Review of attachment 8930261 [details] [diff] [review]:
-----------------------------------------------------------------

Nice tests, thanks

::: js/src/wasm/WasmJS.cpp
@@ +309,5 @@
> +    // Step 6.2.
> +    x = JS::ToInteger(x);
> +
> +    // Step 6.3, allowing caller to supply a more restrictive uint32_t max.
> +    if (x < 0 || x > max) {

nit: can you write it x < 0.0 || x > double(max) to make the implicit conversion explicit?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a91b80c925e
Baldr: use stricter checking for [EnforceRange] types (r=bbouvier)

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/5a91b80c925e