1418210 - `mach mochitest browser/base/content/test/tabs/browser_opened_file_tab_navigated_to_web.js` fails locally

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[Tooru Fujisawa [:arai]]

When I run browser/base/content/test/tabs/browser_opened_file_tab_navigated_to_web.js locally with the following command, it hits timeout:
  ./mach mochitest browser/base/content/test/tabs/browser_opened_file_tab_navigated_to_web.js

it's because of the URL the test expects doesn't match due to symbolic link.
it expects file:///Users/arai/projects/mozilla-unified/obj-master/_tests/testing/mochitest/browser/browser/base/content/test/tabs/dummy_page.html?opened
but the actual URL that appears is file:///Users/arai/projects/mozilla-unified/browser/base/content/test/tabs/dummy_page.html?opened
and BrowserTestUtils.waitForNewTab ignores the tab, and waits for the next tab forever.

Comment 1

[Tooru Fujisawa [:arai]]

to be clear, the difference is
OBJDIR/_tests/testing/mochitest/browser/browser/base/content/test/tabs/dummy_page.html?opened
vs
TOPSRCDIR/browser/base/content/test/tabs/dummy_page.html?opened

Comment 2

[Tooru Fujisawa [:arai]]

this seems to be hiding another issue in bug 1416153

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Normalize symbolic link for test file in browser/base/content/test/tabs/browser_opened_file_tab_navigated_to_web.js.

Locally, test files in OBJDIR can be a symbolic link to the actual file in tree,
and the path generated from symbolic link is differ from the actual URI for the new tab.
This patch normalizes the symbolic link, so that the `uriString` matches to the actual URI.

Comment 4

[:Gijs (he/him)]

Comment on attachment 8930307 [details] [diff] [review]
Normalize symbolic link for test file in browser/base/content/test/tabs/browser_opened_file_tab_navigated_to_web.js.

Review of attachment 8930307 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fe25958d6339
Normalize symbolic link for test file in browser/base/content/test/tabs/browser_opened_file_tab_navigated_to_web.js. r=Gijs

Comment 6

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fe25958d63393c748df119c3bf08254b83f41eae
Bug 1418210 - Normalize symbolic link for test file in browser/base/content/test/tabs/browser_opened_file_tab_navigated_to_web.js. r=Gijs

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/fe25958d6339