Closed Bug 1418219 Opened 2 years ago Closed 2 years ago

Merge MediaCacheStream::NotifyDataLength() and MediaCacheStream::NotifyDataStarted()

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

59 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(1 file)

https://searchfox.org/mozilla-central/rev/9bab9dc5a9472e3c163ab279847d2249322c206e/dom/media/ChannelMediaResource.cpp#275

Since ChannelMediaResource::OnStartRequest() is the only caller, we can merge these 2 functions by passing an additional parameter to NotifyDataStarted() to indicate the stream length.

This will make it easier to offload NotifyDataStarted() from the main thread.
Assignee: nobody → jwwang
Blocks: 1369263
Priority: -- → P3
Attachment #8930377 - Flags: review?(bechen)
Comment on attachment 8930377 [details]
Bug 1418219 - merge NotifyDataLength() and NotifyDataStarted().

https://reviewboard.mozilla.org/r/201518/#review206802
Attachment #8930377 - Flags: review?(bechen) → review+
Attachment #8930377 - Flags: review?(gsquelart)
Comment on attachment 8930377 [details]
Bug 1418219 - merge NotifyDataLength() and NotifyDataStarted().

https://reviewboard.mozilla.org/r/201518/#review206836
Attachment #8930377 - Flags: review?(gsquelart) → review+
Thanks for the reviews!
Version: 58 Branch → 59 Branch
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8a952ea3f5d7
merge NotifyDataLength() and NotifyDataStarted(). r=bechen,gerald
https://hg.mozilla.org/mozilla-central/rev/8a952ea3f5d7
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.