Closed Bug 1418220 Opened 2 years ago Closed 2 years ago

Drop AnimationUtils::IsCoreAPIEnabled(ForCaller) and use nsContentUtils::AnimationsAPICoreEnabled instead

Categories

(Core :: DOM: Animation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: birtles, Assigned: birtles)

References

Details

Attachments

(1 file)

No description provided.
Or perhaps nsDocument::IsWebAnimationsEnabled is better.
Assignee: nobody → bbirtles
Status: NEW → ASSIGNED
Comment on attachment 8929983 [details]
Bug 1418220 - Drop AnimationUtils::IsCoreAPIEnabled(ForCaller) and use nsContentUtils::AnimationsAPICoreEnabled / nsDocument::IsWebAnimationsEnabled instead;

https://reviewboard.mozilla.org/r/201156/#review206248

Nice!

::: commit-message-dd08f:17
(Diff revision 1)
> +
> +That may or not be quite what we want, but this patch doesn't change that except
> +for one call site: KeyframeUtils::GetKeyframesFromObject. This patch changes
> +GetKeyframesFromObject from *not* checking the caller type to checking the
> +caller type. That seems to be the correct behavior here since this is called
> +from KeyframeEffect::SetKeyframes() (i.e. a JS API-facing call site) where we

It might be better to write arguments for the SetKeyframes() to make it clear that the function is only used in JS, i.e.

SetKeyframes(JSContext*, JS::Handle<JSObject*>, ErrorResult&)
Attachment #8929983 - Flags: review?(hikezoe) → review+
Pushed by bbirtles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b828f7a6c2bf
Drop AnimationUtils::IsCoreAPIEnabled(ForCaller) and use nsContentUtils::AnimationsAPICoreEnabled / nsDocument::IsWebAnimationsEnabled instead; r=hiro
https://hg.mozilla.org/mozilla-central/rev/b828f7a6c2bf
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.