JSON Viewer to use ES6 Classes, prop-types and react-dom-factories

RESOLVED FIXED in Firefox 59

Status

enhancement
P2
normal
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: miker, Assigned: miker)

Tracking

unspecified
Firefox 59
Dependency tree / graph

Firefox Tracking Flags

(firefox59 fixed)

Details

Attachments

(1 attachment)

There are a number of reasons for this:

1. We need to have the modules available for code from devtools-core, which uses them.
2. It begins the process of getting rid of React deprecation warnings.
3. It prepares us to upgrade to React 16.

Versioning info from devtools-core github repo:

"prop-types": "^15.6.0"
"react-dom-factories": "^1.0.2"
Comment on attachment 8929393 [details]
Bug 1418250 - JSON Viewer to ES6 Classes, prop-types and react-dom-factories

https://reviewboard.mozilla.org/r/200724/#review205934

Looks good,

R+ assuming my comments are resolved and try is green.

Thanks Mike!
Honza

::: devtools/client/jsonview/components/HeadersPanel.js:88
(Diff revision 1)
>          )
>        );
> -    },
> -  }));
> +    }
> +  }
> +
> +  let HeadersToolbarFactory = createFactory(HeadersToolbar);

I would prefer creating the factory at at the top of the file.

::: devtools/client/jsonview/components/JsonPanel.js:185
(Diff revision 1)
>          )
>        );
> -    },
> -  }));
> +    }
> +  }
> +
> +  let JsonToolbarFactory = createFactory(JsonToolbar);

Again, please move to the top of the file

::: devtools/client/jsonview/components/TextPanel.js:110
(Diff revision 1)
>          )
>        );
> -    },
> -  }));
> +    }
> +  }
> +
> +  let TextToolbarFactory = createFactory(TextToolbar);

Just like in previous cases.
Attachment #8929393 - Flags: review?(odvarko) → review+
Comment on attachment 8929393 [details]
Bug 1418250 - JSON Viewer to ES6 Classes, prop-types and react-dom-factories

https://reviewboard.mozilla.org/r/200724/#review205934

I have moved the requests to split the components into their own files to bug 1418320
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9fa79b8134eb
JSON Viewer to ES6 Classes, prop-types and react-dom-factories r=Honza
https://hg.mozilla.org/mozilla-central/rev/9fa79b8134eb
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.