Closed Bug 1418252 Opened 3 years ago Closed 3 years ago

Make Windows coverage build run Talos

Categories

(Testing :: Code Coverage, enhancement)

enhancement
Not set
normal

Tracking

(firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: marco, Assigned: marco)

References

Details

Attachments

(2 files)

No description provided.
They are not even starting: https://treeherder.mozilla.org/#/jobs?repo=try&revision=aab3e72d22950517f8668d24098265cac0a824bc&selectedJob=145559958.

Joel, any idea why they are not scheduled?
Flags: needinfo?(jmaher)
we need buildbot builders if we are running talos.  If you look here, we specify hardware:
https://searchfox.org/mozilla-central/source/taskcluster/ci/test/talos.yml#4

and you  can see the windows worker types here:
https://searchfox.org/mozilla-central/source/taskcluster/taskgraph/transforms/tests.py#885

I would copy line 897 to make it work for win10 ccov:
 if test.get('suite', '') == 'talos' and test['build-platform'] != 'linux64-ccov/opt':
Flags: needinfo?(jmaher)
OK, so basically this is the same as bug 1417496.
not really, we don't need hardware to run talos on when we are just collecting coverage (i.e. no need for perf results), it is ok to run on a VM and we know the tests pass on a VM :)

As for reftests, those just don't pass on a VM, and fail to run- machines die often and we sometimes never get results.
Attached patch PatchSplinter Review
Ah, I see!

So, something like this?
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Attachment #8929435 - Flags: feedback?(jmaher)
Comment on attachment 8929435 [details] [diff] [review]
Patch

Review of attachment 8929435 [details] [diff] [review]:
-----------------------------------------------------------------

yes, this should do the trick.
Attachment #8929435 - Flags: feedback?(jmaher) → feedback+
With this fix, the tests are actually scheduled on taskcluster: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1100e0ecdea1e25fc599eaf75ed24274639cfe87.

They are still failing because windows_taskcluster_config.py is broken, but I will fix it in another patch.
Attachment #8929554 - Flags: review?(jmaher)
Comment on attachment 8929554 [details] [diff] [review]
Allow 'virtualization' key to be keyed by test platform

Review of attachment 8929554 [details] [diff] [review]:
-----------------------------------------------------------------

this ended up being a simpler one to solve!
Attachment #8929554 - Flags: review?(jmaher) → review+
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f45f015cc1d1
Make talos tests run in Windows coverage build. r=jmaher
https://hg.mozilla.org/integration/mozilla-inbound/rev/625e1e4e9c4f
Allow 'virtualization' key to be keyed by test platform. r=jmaher
https://hg.mozilla.org/integration/mozilla-inbound/rev/1e2bd5798640
Add missing 'sys' import. r=jmaher
https://hg.mozilla.org/mozilla-central/rev/f45f015cc1d1
https://hg.mozilla.org/mozilla-central/rev/625e1e4e9c4f
https://hg.mozilla.org/mozilla-central/rev/1e2bd5798640
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.