1418310 - Reorder Attachments: Some access keys close panel, others don't.

Status: NEW

(Thunderbird :: Message Compose Window, defect)

Description

[Thomas D. (:thomas8)]

+++ This bug was initially created as a clone of Bug #1417856 +++

STR

1) focus in attachment pane, select any attachment except first
2) Alt+X to open reorder attachments panel
3) Alt+T to move selected attachments to top
4) Alt+B to move selected attachments to bottom

Actual result

3) after Alt+T for "move-to-top", panel stays open
4) after Alt+B for "move-to-bottom", panel closes (same problem also seen with other access keys)

Expected result

Panel should stay open for any access keys of panel commands, just as it does when commands are clicked. There should be no difference between keyboard- and mouse-invoking the command.

Comment 1

[Thomas D. (:thomas8)]

I accidentally filed bug 1425891 as a duplicate of this, where we decided to just remove all access keys.

But the symptoms are still the same, now limited to Alt+Y keyboard shortcut.

STR:

0) This is probably Windows-specific, where Alt is the menu access key/accelerator (tested on Win10).
1) focus in attachment pane
2) Alt+X to open reorder attachments panel
3) Alt+Y to reorder attachments

Actual result

3) after Alt+Y for "reorder", panel closes.
(but ironically, when you choose a main menu access key combo like Alt+V (View menu), panel will correctly stay open; unfortunately, it also hijacks that combo so that it can no longer be used for the main menu.)

Expected result

Panel should stay open for any access/shortcut keys of panel commands, just as it does when commands are clicked (and more so when that keyboard shortcut isn't even taken for anything else anywhere, like main menu access keys or so). There should be no difference between keyboard- and mouse-invoking the command.
I's also think that if we attach keyboard shortcuts or access keys to commands of attachmentBucketController, they should be limited to be effective only when attachment bucket has focus, no?

I suspect that the Alt key is getting some special treatment which unfortunately is too greedy in this case.