Closed Bug 1418361 Opened 2 years ago Closed 2 years ago

Don't hit fallback for simple nsDisplayThemedBackground cases on Linux.

Categories

(Core :: Graphics: WebRender, enhancement, P1)

Product:
Core
Component:
Graphics: WebRender
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox57 --- unaffected
firefox59 --- disabled
firefox60 --- fixed

People

(Reporter: nical, Assigned: lsalzman)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [wr-reserve] [gfx-noted])

Attachments

(1 file)

push GTK window background color rect for WR
3.54 KB, patch
nical
: review+
Details | Diff | Splinter Review 
+++ This bug was initially created as a clone of Bug #1417197 +++

Same as bug 1417197 on Linux where a full-window opaque solid color ends up being painted on the content process and uploaded on the render thread instead of emitting a simple and cheap rect display item.
Whiteboard: [wr-reserve] → [wr-mvp] [triage]
Blocks: stage-wr-trains
status-firefox57: --- → unaffected
Whiteboard: [wr-mvp] [triage] → [wr-mvp] [triage][wr-reserve-candidate]
Assignee: nical.bugzilla → nobody
Priority: P1 → P3
Whiteboard: [wr-mvp] [triage][wr-reserve-candidate] → [wr-reserve]
Blocks: 1417046
Whiteboard: [wr-reserve] → [wr-reserve] [gfx-noted]
Did a lot of digging inside GTK3. It remains possible that a theme might use a gradient or image and/or box shadow as a window background. However, GTK3 doesn't really have a nice (or any) ways to query those things out of the style context. But for most intents, we are probably safe just assuming there is only the background color. Not sure if any styles actually do anything else.

That said, we already safely query the background color of the window's style context in gtk/nsLookAndFeel, so this just retrieves that and builds the necessary rect from it.
Attachment #8944333 - Flags: review?(nical.bugzilla)
Comment on attachment 8944333 [details] [diff] [review]
push GTK window background color rect for WR

Review of attachment 8944333 [details] [diff] [review]:
-----------------------------------------------------------------

Sweet!
Attachment #8944333 - Flags: review?(nical.bugzilla) → review+
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd692ac007bd
push GTK window background color rect for WR. r=nical
Assignee: nobody → lsalzman
Status: NEW → ASSIGNED
Priority: P3 → P1
https://hg.mozilla.org/mozilla-central/rev/bd692ac007bd
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.