141849 - After closing print preview window, selecting print doesn't open print dialog

Status: VERIFIED FIXED

(Core :: Print Preview, defect, P1)

Description

[Chris Petersen]

Build: 2002-05-02-05
Platform: OS X 10.1.4
Expected Results: Selecting print should open print dialog
What I got: Print dialog doesn't open

Steps to reproduce:

1) Go to mozilla.org
2) Select Print Preview from File
3) Click Close button in preview window
4) Select Print from File menu
5) Print dialog doesn't open

Comment 1

[Conrad Carlen (not reading bugmail)]

My fault - I did the Mac work for that checkin. Looking at it as soon as my
build finishes.

Comment 2

[Conrad Carlen (not reading bugmail)]

Found out why this happens and I don't think it's a new bug.

http://lxr.mozilla.org/mozilla/source/content/base/src/nsDocumentViewer.cpp#6893

Reason it fails is that when printing *after* doing a print preview,
mIsDoingPrintPreview will be FALSE. Notice that when it's FALSE, the value is
never set to FALSE in the print settings (it was set to TRUE by the previous
print preview) and this causes failure.

This will be fixed by bug 115136 - not fixing before that.

Comment 3

[Conrad Carlen (not reading bugmail)]

This was fixed by bug 115136. Just checked with my post-checkin build.

Comment 4

[Chris Petersen]

This is fixed on trunk (0S X 2002-05-20-08). Still a issue on branch (OS X
2002-05-22-11 1.0.0)