Closed
Bug 1418527
Opened 8 years ago
Closed 8 years ago
Drop the dlopen() hard-coded paths from pingsender on Linux
Categories
(Toolkit :: Telemetry, enhancement, P3)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: gsvelto, Assigned: gsvelto)
Details
Attachments
(1 file)
See bug 1401339 comment 26 for more details on why they're not needed anymore. Long story short: they're useless added complexity and hard to maintain on different architectures.
Updated•8 years ago
|
Priority: -- → P3
| Comment hidden (mozreview-request) |
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8931627 [details]
Bug 1418527 - Drop hardcoded libcurl paths from the pingsender on Linux;
https://reviewboard.mozilla.org/r/202792/#review208110
r+ as this basically restores the code to pre-bug 1401339. Let's make sure we don't regress the pingsender on the supported platform and flag QA for that if needed.
Attachment #8931627 -
Flags: review?(alessio.placitelli) → review+
| Assignee | ||
Updated•8 years ago
|
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
| Assignee | ||
Comment 3•8 years ago
|
||
(In reply to Alessio Placitelli [:Dexter] from comment #2)
> r+ as this basically restores the code to pre-bug 1401339.
Not really, it's only for Linux, on Mac we keep the hard-coded paths.
> Let's make sure
> we don't regress the pingsender on the supported platform and flag QA for
> that if needed.
We have test coverage across all platforms fortunately.
| Assignee | ||
Comment 4•8 years ago
|
||
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9a787d89b565
Drop hardcoded libcurl paths from the pingsender on Linux; r=Dexter
Comment 6•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•