Open Bug 1418627 Opened 3 years ago Updated 3 years ago

Intermittent browser/components/sessionstore/test/browser_524745.js | uncaught exception - TypeError: selectedWindow is undefined at test/</</<@chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_524745.js:27:12

Categories

(Firefox :: Session Restore, defect, P2)

Product:
Firefox
Component:
Session Restore
Type:
defect

Tracking

()

Status:
ASSIGNED
Tracking Flags:
Tracking Status
firefox-esr60 --- disabled
firefox61 --- wontfix
firefox62 --- disabled

People

(Reporter: intermittent-bug-filer, Assigned: mikedeboer)

References

Details

(Keywords: intermittent-failure, leave-open, regressionwindow-wanted, Whiteboard: [stockwell disabled])

Attachments

(2 files)

Bug 1418627 - make sure to test window data at a positive array index, otherwise it may be null.
59 bytes, text/x-review-board-request
Details
Skipped browser_524745.js on Windows 10 !ccov for frequent failures
672 bytes, patch
jmaher
: review+
Details | Diff | Splinter Review 
There are 33 failures in the last 7 days. All of them on Windows 10.

Relevant log info:

20:44:44     INFO -  427 INFO TEST-PASS | browser/components/sessionstore/test/browser_524745.js | selectedWindow is window_B -
20:44:44     INFO -  Buffered messages finished
20:44:44    ERROR -  428 INFO TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_524745.js | uncaught exception - TypeError: selectedWindow is undefined at test/</</<@chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_524745.js:27:12
20:44:44     INFO -  SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
20:44:44     INFO -  Stack trace:
20:44:44     INFO -  chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:1655
20:44:44     INFO -  GECKO(6620) | JavaScript error: chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_524745.js, line 27: TypeError: selectedWindow is undefined
20:44:44     INFO -  429 INFO Console message: [JavaScript Error: "TypeError: selectedWindow is undefined" {file: "chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_524745.js" line: 27}]

The issue seems to be at "ok(!selectedWindow.extData || !selectedWindow.extData[uniqKey]," :

   // Now minimize window_B. The selected window shouldn't have the secret data
      window_B.minimize();
      waitForFocus(function() {
        state = JSON.parse(ss.getBrowserState());
        selectedWindow = state.windows[state.selectedWindow - 1];
        ok(!selectedWindow.extData || !selectedWindow.extData[uniqKey],
           "selectedWindow is not window_B after minimizing it");


:mikedeboer, can you please take a look?
Flags: needinfo?(mdeboer)
Whiteboard: [stockwell needswork]
This one has been quiet for five months, basically since its initial filing, and now suddenly goes into frequent failing mode. This has to be caused by something.
Do you know/ can you find out which push this behavior started?
Flags: needinfo?(mdeboer) → needinfo?(nbeleuzu)
Keywords: regressionwindow-wanted
Blocks: 1372694
Flags: needinfo?(mdeboer)
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Priority: P5 → P2
There is no activity on this bug in the last 8 days and the 
[stockwell disable-recommended]  tag was set, so I made a patch to disable this on windows 10 !ccov.
Flags: needinfo?(jmaher)
Attachment #8976053 - Flags: review?(jmaher)
Summary:
- 52 failures in the last 7 days
- all the failures are on the windows10-64 platform
- failures per build types: 6 debug, 17 opt, 29 pgo
- recent log file: https://treeherder.mozilla.org/logviewer.html#?repo=autoland&job_id=178644306&lineNumber=3075

Snippet with the failure:
23:32:33     INFO -  283 INFO TEST-START | browser/components/sessionstore/test/browser_524745.js
23:32:33     INFO -  TEST-INFO | started process screenshot
23:32:33     INFO -  TEST-INFO | screenshot: exit 0
23:32:33     INFO -  Buffered messages logged at 23:32:33
23:32:33     INFO -  284 INFO TEST-PASS | browser/components/sessionstore/test/browser_524745.js | selectedWindow is window_B -
23:32:33     INFO -  Buffered messages finished
23:32:33    ERROR -  285 INFO TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_524745.js | uncaught exception - TypeError: selectedWindow is undefined at test/</</<@chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_524745.js:27:12
23:32:33     INFO -  SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
23:32:33     INFO -  Stack trace:
23:32:33     INFO -  chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:1655
23:32:33     INFO -  GECKO(7824) | JavaScript error: chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_524745.js, line 27: TypeError: selectedWindow is undefined
23:32:33     INFO -  286 INFO Console message: [JavaScript Error: "TypeError: selectedWindow is undefined" {file: "chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_524745.js" line: 27}]
23:32:33     INFO -  test/</</<@chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_524745.js:27:12
23:32:33     INFO -  SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
23:33:18     INFO -  Not taking screenshot here: see the one that was previously logged
23:33:18    ERROR -  287 INFO TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_524745.js | Test timed out -
23:33:18     INFO -  GECKO(7824) | MEMORY STAT | vsize 2099183MB | vsizeMaxContiguous 128097436MB | residentFast 364MB | heapAllocated 105MB
23:33:18     INFO -  288 INFO TEST-OK | browser/components/sessionstore/test/browser_524745.js | took 45045ms
23:33:18     INFO -  289 INFO checking window state
23:33:18     INFO -  Not taking screenshot here: see the one that was previously logged
23:33:18    ERROR -  290 INFO TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_524745.js | Found a browser window after previous test timed out -
Comment on attachment 8976053 [details] [diff] [review]
Skipped browser_524745.js on Windows 10 !ccov for frequent failures

Review of attachment 8976053 [details] [diff] [review]:
-----------------------------------------------------------------

perfect
Attachment #8976053 - Flags: review?(jmaher) → review+
Flags: needinfo?(jmaher)
Keywords: checkin-needed, leave-open
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/505667081ae2
disable browser_524745.js on Windows 10 !ccov for frequent failures. r=jmaher
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.