Closed Bug 1418671 Opened 3 years ago Closed 3 years ago

Failing lint builds - source-test-file-metadata-bugzilla-components

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nataliaCs, Assigned: tomprince)

References

Details

Attachments

(1 file)

Flags: needinfo?(mozilla)
Keywords: leave-open
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/comm-central/rev/0d601be171e5
Disable linting temporarily due to cache poisoning. r=me
I've turned off linting jobs on comm-central while a fix is pending.
Flags: needinfo?(mozilla)
Comment on attachment 8929799 [details]
Bug 1418671: Use a separate cache for builds that checkout comm-central;

https://reviewboard.mozilla.org/r/201028/#review206468

The shared store needs to be on the same volume as the checkouts to ensure things don't get out of sync. If they weren't on the same store, you could end up in a situation where the checkout cache has a changeset that isn't in the store cache. While I think robustcheckout will or could deal with this, it is a bad situation because it requires the working directory to be blown away.
Attachment #8929799 - Flags: review?(gps) → review-
Comment on attachment 8929799 [details]
Bug 1418671: Use a separate cache for builds that checkout comm-central;

https://reviewboard.mozilla.org/r/201028/#review206468

All the build jobs already don't use the same volume, since they do a checkout in the workspace cache, but still point to the checkout cache for the shared store.
Attachment #8929799 - Flags: review- → review?(gps)
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Comment on attachment 8929799 [details]
Bug 1418671: Use a separate cache for builds that checkout comm-central;

https://reviewboard.mozilla.org/r/201028/#review206468

Then the build tasks are buggy. The reason we aren't bit by this is because we only run a single concurrent task on the build workers. For the workers where we can run multiple tasks concurrently (like decision workers), the checkout is on the same cache as the store.

I'm *very* nervous about breaking this standard and mixing and matching checkouts and stores. I may just add a sanity check to run-task that fails the task if cache spanning is detected.
Comment on attachment 8929799 [details]
Bug 1418671: Use a separate cache for builds that checkout comm-central;

https://reviewboard.mozilla.org/r/201028/#review211244

This still gets an r- from me because of cache spanning. To support comm-central, let's put something in the cache name (not necessarily the filesystem path) to delimit which *scope* caches belong to.
Attachment #8929799 - Flags: review?(gps) → review-
Comment on attachment 8929799 [details]
Bug 1418671: Use a separate cache for builds that checkout comm-central;

https://reviewboard.mozilla.org/r/201028/#review206468

Thanks for the more detailed explanation.
Comment on attachment 8929799 [details]
Bug 1418671: Use a separate cache for builds that checkout comm-central;

https://reviewboard.mozilla.org/r/201028/#review213958
Attachment #8929799 - Flags: review?(gps) → review+
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/integration/autoland/rev/d38774aa733f
Use a separate cache for builds that checkout comm-central; r=gps
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.