1418718 - regression: White discoloration on tabs behind text

Status: RESOLVED DUPLICATE of bug 1424673

(Core :: Graphics: WebRender, defect, P1)

Description

[Asif Youssuff]

Attachment: Screenshot at 2017-11-18 19-00-08.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20171118100420

Steps to reproduce:

In about:config:
– set “gfx.webrender.enabled” to true,
– set “gfx.webrender.blob-images” to true,
– if you are on Linux, set “layers.acceleration.force-enabled” to true.

I have the "Safari Color Gradation" theme installed: https://addons.mozilla.org/en-US/firefox/addon/safari-color-gradation/ and am using an existing session. 


Actual results:

White discoloration on tabs behind text. See screenshot. 


Expected results:

As before it regressed.

Comment 1

[Asif Youssuff]

 8:53.40 INFO: Narrowed inbound regression window from [ef9858e9, df95c863] (3 builds) to [ef9858e9, cdf4bb1c] (2 builds) (~1 steps left)
 8:53.40 INFO: No more inbound revisions, bisection finished.
 8:53.40 INFO: Last good revision: ef9858e9ad38718eea180a62bb5b65561ad57d91
 8:53.40 INFO: First bad revision: cdf4bb1c6af6e53643d2beb0f10a2ce29207ff5e
 8:53.40 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=ef9858e9ad38718eea180a62bb5b65561ad57d91&tochange=cdf4bb1c6af6e53643d2beb0f10a2ce29207ff5e

Comment 2

[Darkspirit]

Attachment: Screenshot_20171119_012445.png

Nightly 59 x64 20171118100420 de_DE d4753dc14b2ab9c42123b6d60a68106df40f45cd @ Debian Testing (KDE, Radeon RX480)
fresh profile: layers.acceleration.force-enabled, gfx.webrender.enabled, gfx.webrender.blob-images

I can reproduce this. Especially behind and around "about:config" it almost looks like white. Fixed by disabling WebRender.

----------------

1. run mozregression
2. install https://addons.mozilla.org/en-US/firefox/addon/safari-color-gradation/
3. open about:config, switch to another tab, hover the about:config tab

(Reused commands from bug 1418126 comment 5)
good (last commit before the webrender update):
mozregression --repo autoland --launch ef9858e9ad38 --pref "layers.acceleration.force-enabled:true" "gfx.webrender.enabled:true" "gfx.webrender.blob-images:true"

bad (webrender update):
mozregression --repo autoland --launch c80c224d6b0c --pref "layers.acceleration.force-enabled:true" "gfx.webrender.enabled:true" "gfx.webrender.blob-images:true"

Comment 3

[Darkspirit]

Attachment: Screenshot_20171124_000507.png

(20171123100420) Probably the same issue. Usually it only happens after some time.
Theme: https://twitter.com/FirefoxNightly/status/933717466513072128

Comment 4

[Asif Youssuff]

@Jan, I tried out that theme and thought it looked great except for the text; didn't even think about trying it on a non WR profile. Glad to know it's a bug.

Comment 6

[Dirkjan Ochtman (:djc)]

This seems very visible to first-time WebRender testers -- shouldn't that make it [wr-mvp] (and > P3)?

Comment 9

[tjtncks]

This discoloration isn't always white, if engine thinks letter color is white enough, it will create black discoloration instead. (ex: https://addons.mozilla.org/en-US/firefox/addon/firefox-quantum-nightly/  )

Comment 10

[Kartikaya Gupta (email:[e-mail])]

I'm not able to reproduce this bug on OS X either using rev cdf4bb1c6af6e53643d2beb0f10a2ce29207ff5e ("first bad revision") or the current nightly. Might not affect OS X, or maybe it's intermittent, or maybe I'm just not seeing it. In the screenshot in comment 0 I can't see anything wrong; the screenshot in comment 2 shows some discoloration which is what I'm looking for and not finding when I try to repro.

Comment 11

[Jeff Muizelaar [:jrmuizel]]

I can still reproduce this. You need to use a light weight theme.

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Ah, I see it in Nightly using either the "A Web Browser Renaissance" theme or the recommended "Pastel Gradient" theme. Doesn't show up with other themes as far as I can tell. I'll try to bisect into bug 1417062.

Comment 13

[Kartikaya Gupta (email:[e-mail])]

WR regression range is:

* 54e79688 Auto merge of #2031 - glennw:pic28, r=kvark
* fadae648 Address review comments and fix Gecko test failures.
* 0633bb37 Hide StackingContext
* 6ca43c34 Introduce PicturePrimitive::Image.

I filed servo/webrender#2176 for it.

Comment 15

[Andrew Osmond [:aosmond] (he/him)]

This is working in nightly, and after running mozregression + the Quantum Nightly theme, I found it was fixed by bug 1424673.

Comment 16

[Asif Youssuff]

@Andrew, does that mean that the servo/webrender#2176 ticket should be closed as well? I can't do this, but figured I would ask.