1418736 - ipfs-js in one tab causes all of Firefox's tabs to crash

Status: UNCONFIRMED

(Core :: WebRTC, defect, P3)

Description

[interfect]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171115094513

Steps to reproduce:

1. Go to https://ipfs.io/ipfs/QmYjSUG7bUaNDYybSdvcq5JZ1jUNdoNdCn4rC1rQCvge8u/ (which is a web page that uses ipfs-js) in Firefox 57.0 on Ubuntu 17.10. Any other page using ipfs-js 0.26.0 should also work.

1.5: The offending page will throw up `ICE failed, add a TURN server and see about:webrtc for more details` messages in the console, which may be related.

2. Wait for a few minutes, while browsing around in other tabs.


Actual results:

Eventually the page you are on will disappear and you will get a message that your tab has crashed. Tabing over to another tab causes the page in that tab to be reloaded from scratch. Whatever crash happens seems to bring down all the tabs but not the browser itself; you can reload pages and continue browsing.

I've observed being taken to the https://ipfs.io/ipfs/QmYjSUG7bUaNDYybSdvcq5JZ1jUNdoNdCn4rC1rQCvge8u/ tab when the crash happens, which immediately reloads itself.


Expected results:

At the very least, a misbehaving ipfs-js-using tab should crash only itself and not all of the other tabs.

Ideally, none of my tabs should crash and the application should work correctly.

Comment 1

[Kohei Yoshino [:kohei]]

Please provide your crash ID: https://support.mozilla.org/kb/mozillacrashreporter

Comment 2

[interfect]

There's no crash report generated; about:crashes stays empty and the browser as a whole stays running, with the crash reporter never being launched. Only the tabs ("Web Content" processes?) crash.

The crashed tabs have a "Gah. Your tab just crashed." page and look like this: https://imgur.com/a/Y8zNw

Comment 3

[Jason Orendorff [:jorendorff]]

interfect, does about:addons show that you've got anything installed? (Look under Extensions.) Any other web sites in particular we should try?

Jan, could you try to reproduce this on Linux? Didn't happen for me on Mac.

Comment 4

[Jason Orendorff [:jorendorff]]

P1 if we can reproduce...

Comment 5

[Benjamin Bouvier [:bbouvier] (inactive)]

I get the following error in the console when trying to reproduce:

Can't set property: 'links' is immutable

Comment 6

[interfect]

One caveat is that the linked reproduction page always uses the latest ipfs-js. With the release of ipfs-js 0.27.0, which disables WebRTC by default, the linked page will no longer crash because the latest ipfs-js has worked around it. But I believe ipfs-js 0.26.0 can still crash Firefox.

I also managed to reproduce the issue with https://dweb.me/examples/example_block.html which bundles 0.26.0.

I actually got that page to crash the whole browser; that report is here: https://crash-stats.mozilla.com/report/index/e96a8622-ea85-4592-87cb-6462b0171205#tab-details

My extensions are:

GNOME Shell Integrations
Metamask
Privacy Badger
uBlock Origin
YesScript2

Comment 7

[Jan de Mooij [:jandem]]

(In reply to interfect from comment #6)
> I actually got that page to crash the whole browser; that report is here:
> https://crash-stats.mozilla.com/report/index/e96a8622-ea85-4592-87cb-
> 6462b0171205#tab-details

That's bug 1366808 - it's probably because your build got updated or something.

Comment 8

[Jan de Mooij [:jandem]]

Why do we think this is a JS engine bug? We still don't have any signatures or crash reports.

(In reply to interfect from comment #6)
> I also managed to reproduce the issue with
> https://dweb.me/examples/example_block.html which bundles 0.26.0.

Does this still reproduce for you? Do you have more precise STR? That page loads fine for me on OS X.

Comment 9

[interfect]

I can definitely confirm that I still have my tabs crash in Firefox 57.0.1 on Ubuntu 17.10 on the https://dweb.me/examples/example_block.html URL. Still no crash report, as the browser as a whole stays up and that other crash I submitted a report from was apparently unrelated.

I don't believe the issue occurs on OS X.

Steps to reproduce (revised):

1. Go to https://dweb.me/examples/example_block.html (which is a web page that uses ipfs-js) in Firefox 57.0.1 on Ubuntu 17.10. Any other page using ipfs-js 0.26.0 should also work.

1.5. The page will try and use WebRTC, which is probably related to the crash.

2. Wait for a few minutes, while browsing around in other tabs.

Actual results:

Eventually the page you are on will disappear and you will get a message that your tab has crashed. Tabing over to another tab causes the page in that tab to be reloaded from scratch. Whatever crash happens seems to bring down all the tabs but not the browser itself; you can reload pages and continue browsing.

The IPFS folks think the crash might be the result of "too many" threads and/or WebRTC connections. See https://github.com/ipfs/js-ipfs/issues/1088#issuecomment-347772291 and https://github.com/ipfs/js-ipfs/issues/950#issuecomment-344888858

Is this behavior (the tab you are on crashing, all the other tabs losing their state, and the offending tab refreshing itself) what is expected if a tab tries to consume large amounts of system resources via WebRTC?

Comment 10

[Jan de Mooij [:jandem]]

Let's move this to the WebRTC component.

Comment 11

[Benjamin Bouvier [:bbouvier] (inactive)]

For what it's worth, I opened this in many tabs and couldn't get a crash after ten minutes. But I had a 1:1 on talky.io which also uses webrtc, and in 20 minutes it crashed twice, with the same symptoms (no crash reports).

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

Moving to p3 because no activity for at least 24 weeks.
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information