1418792 - Cannot move window with touch in GNOME

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P5)

Description

[rugk]

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20171113102334

Steps to reproduce:

1. Open Firefox.
2. Try to move the window at the title bar via touch.

(tested with and without widget.allow-client-side-decoration)

GNOME v3.26, Fedora 27, Wayland


Actual results:

It does not move. I cannot "grab" it like that. In other GNOME application it works.

It works with the mouse.


Expected results:

The window should be movable by touch.

Likely related to Bug 1418611, which is about the "about window" and closing it, however. Closing the Firefox main window via touch, works.

Comment 1

[rugk]

Ah just could find out the issue: I am using Wayland, but as Firefox does not support Wayland yet, I tried the NightlyWayland build (flatpak) and it does indeed solve this issue.

Comment 2

[blaimi]

This affects every XWayland-Client. See https://bugzilla.gnome.org/show_bug.cgi?id=770185.

Duplicates:
* https://bugzilla.mozilla.org/show_bug.cgi?id=1418611
* https://bugzilla.gnome.org/show_bug.cgi?id=786910
* https://bugzilla.redhat.com/show_bug.cgi?id=1408554
* https://bbs.archlinux.org/viewtopic.php?id=219808

Comment 3

[rugk]

Okay, just tried it again with latest nightly and potentially discovered a different or similar issue.

And yes, it does work, but only when drawInTitlebar is disabled. When I allow drawing, it cannot be moved anymore.

60.0a1, otherwise same system

Comment 4

[blaimi]

(In reply to rugk from comment #3)
> 60.0a1, otherwise same system

60.0a1 has Wayland-Spport built in. No XWayland is used if wayland is detected on start

Comment 5

[rugk]

I can confirm, that with FF 66 on Fedora 29, this bugs still happens. (Related Bug 1418611 has been fixed in the meantime, i.e. I can move the about window, but I cannot move the main window via touch.)

I can totally minimize/maximize/close the window, but I cannot move it via touch.

And in contrast to what has been said before, I never saw this issue with other apps.
And as I think also Firefox uses Wayland by default now, the fault cannot be XWayland…

Comment 6

[rugk]

BTW, also reported downstream now: https://bugzilla.redhat.com/show_bug.cgi?id=1694329

Comment 7

[russianneuromancer]

This issue is still reproducible with today Firefox nightly build (70.0a1 2019-08-09) on Gnome Shell 3.32.2 Wayland session on Ubuntu 19.04.

Comment 9

[liranpiade]

I can report the same issue on X11 (I can't use Wayland because I use Nvidia-PRIME).

Enabling a regular system title bar allows me to drag with touch, but I want it disabled. I use the MOZ_XINPUT2 environment variable which fixes dragging within the webpage.

Comment 10

[personalizedrefrigerator]

Experiencing the same issue on KDE Plasma, Fedora 33, as well as GNOME Shell 3.38.1 on PoP OS. On Fedora, this issue is present under both Wayland and X11.

Tested with firefox_wayland, firefox_x11 packages, firefox installed from snapd on Fedora.

On PoP OS, I am running Firefox 82.0.3.

Comment 11

[personalizedrefrigerator]

When the window is maximized, if I start dragging above the top of the window, dragging works as expected. Starting the gesture on the titlebar, however, does not move the window.

Comment 12

[Gero3977]

(In reply to personalizedrefrigerator from comment #11)

When the window is maximized, if I start dragging above the top of the window, dragging works as expected. Starting the gesture on the titlebar, however, does not move the window.

I see the same behavior. Arch Linux, Gnome 3.38.2, Wayland, Firefox 84.0 running with Wayland support not X11 mode

Comment 13

[Gero3977]

Oh and this is on a Surface Go

Comment 14

[Esokrarkose]

Same behavior for me on an XPS 13 2-in-1. How is this issue related to https://bugzilla.mozilla.org/show_bug.cgi?id=1283299 ?

Comment 15

[Jan Horak [:jhorak]]

Attachment: Bug 1418792 Start drag operation on touch event on draggable area; r=stransky

Add support for dragging window on touch event.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61c28c4c667c
Start drag operation on touch event on draggable area; r=stransky

Comment 17

[Dorel Luca [:dluca]]

Backed out changeset 61c28c4c667c (bug 1418792) for Build bustage in gecko/widget/gtk/nsWindow.cpp. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=337085603&repo=autoland&lineNumber=30356

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=61c28c4c667c20b2a4338b1e3aa46fb73cea7699

Backout:
https://hg.mozilla.org/integration/autoland/rev/db6143aa615293ce245b8709999a17885cc026f2

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/568884c45cf9
Start drag operation on touch event on draggable area; r=stransky

Comment 19

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/568884c45cf9

Comment 20

[personalizedrefrigerator]

May be related to https://bugzilla.mozilla.org/show_bug.cgi?id=1722899

Comment 21

[personalizedrefrigerator]

Attachment: Bug 1418792 - Send TouchCancel event just before dragging window

gdk takes touch-move and touch-end events when dragging the window.
As a result, the touch-start event was propagated, but not touch-end, making firefox think
that all subsequent touches were in addition to the original, breaking mosst touch screen input
(on Linux with MOZ_USE_XINPUT2).

Comment 22

[Phabricator Automation]

Comment on attachment 9247419 [details]
Bug 1418792 - Send TouchCancel event just before dragging window

Revision D129349 was moved to bug 1722899. Setting attachment 9247419 [details] to obsolete.

Comment 23

[Phabricator Automation]

Comment on attachment 9247419 [details]
Bug 1418792 - Send TouchCancel event just before dragging window

Revision D129349 was moved to bug 1722899. Setting attachment 9247419 [details] to obsolete.