Closed
Bug 1418842
Opened 7 years ago
Closed 7 years ago
Fix JS_OOM_BREAKPOINT on MSVC
Categories
(Core :: JavaScript Engine, enhancement, P5)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla59
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
Details
Attachments
(1 file)
|
958 bytes,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
MSVC complains about |asm("")| in js_failedAllocBreakpoint
|
Assignee | |
Comment 1•7 years ago
|
||
* When using --enable-oom-breakpoint configure options. This is just a developer convenience that works on Linux but is broken on Windows.
|
|
Assignee | |
Comment 2•7 years ago
|
||
Use MSVC __asm syntax on that compiler.
|
|
Assignee | |
Updated•7 years ago
|
Severity: normal → trivial
Priority: -- → P5
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8929896 [details] [diff] [review] 0001-Bug-1418842-Support-JS_OOM_BREAKPOINT-on-MSVC.-r-sfi.patch Review of attachment 8929896 [details] [diff] [review]: ----------------------------------------------------------------- I can't say I really know anything about MSVC asm syntax, nor what the various compilers' rules really are for avoiding inlining, but if this works then it sounds good to me.
Attachment #8929896 -
Flags: review?(sphink) → review+
|
|
Assignee | |
Comment 4•7 years ago
|
||
Related code already in tree: https://searchfox.org/mozilla-central/rev/c9214daa09e3eb8246b1448e469df1652a140825/js/src/jsnativestack.cpp#31-60 And, it did allow me to fix an OOM test bug, so better than it was before anyways.
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by toros@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0358f16bf82c Support JS_OOM_BREAKPOINT on MSVC. r=sfink
Keywords: checkin-needed
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0358f16bf82c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in
before you can comment on or make changes to this bug.
Description
•